fix(dialog): retain filtered alerts - #588
Open
benletchford wants to merge 1 commit into
Open
Conversation
benletchford
marked this pull request as ready for review
August 13, 2026 22:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #578
Cause
Multi-button Alert-family calls were made interactive only when
filterProcwas NIL. A non-NIL filter procedure therefore caused Systemless to skip presentation and immediately return the default item. The issue reproducer interpreted that synthetic “I disagree” result as a refusal of its compatibility notice and exited through its correctly chainedExitToShellpatch.Fix
Keep multi-button alerts modal and visible regardless of whether a filter procedure is supplied. Systemless still does not invoke the custom guest callback, but standard button, mouse, and Return handling remain available instead of silently selecting an answer.
Evidence
The authentic issue reproducer now displays its full 680x0 compatibility notice with both “I agree” and “I disagree” buttons and remains in the modal alert instead of exiting after 41,190 guest instructions.
Tests
cargo test --lib alert_with_filter_proc_keeps_multi_button_dialog_interactive --no-default-featurescargo test --lib --no-default-features(2,941 passed, 3 ignored)