Skip to content

fix(standard-file): restore classic Open dialog - #574

Merged
benletchford merged 1 commit into
masterfrom
dev/complete-standard-file-open
Aug 17, 2026
Merged

fix(standard-file): restore classic Open dialog#574
benletchford merged 1 commit into
masterfrom
dev/complete-standard-file-open

Conversation

@benletchford

Copy link
Copy Markdown
Owner

Closes #449.

Cause

The retained Standard File get path synthesized a reduced three-item panel and enumerated only files. That discarded the classic volume, directory-navigation, scrollbar, and disabled-control state, and old-style SFGetFile calls ignored their requested dialog position.

Fix

  • Restore the classic Open dialog structure: volume selector and label, folder/file list, scrollbar, disabled Eject, Desktop, Cancel, and context-sensitive Open controls.
  • Retain directory state so folders can be opened and Desktop navigation refreshes the visible list.
  • Honor the old-style dialog origin while preserving modern centering and the original reply/stack ABI.
  • Remove synthetic empty-state copy and render disabled classic button labels with disabled ink.

Verification

  • cargo test --lib — 2,952 passed, 3 ignored.
  • Focused modern, old-style, navigation, cancellation, and disabled-control regression tests.
  • Damage Incorporated Open-dialog flow exercised end to end; classic structure, placement, navigation controls, and disabled states visually confirmed.

@benletchford
benletchford merged commit 88e769d into master Aug 17, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Standard File Open dialog omits volume and navigation controls

1 participant