LanguageTool: enable 19 more rules (judgment tier) + fix their hits - #1957
Merged
Conversation
Second evidence-driven pass over the disabled list, covering rules whose
hits are real errors but need a judgment call (reword, hyphenation house
style, or the tool's own suggestion is wrong).
Enabled 19 rules, every corpus hit fixed:
Compound/agreement typos: MAKER_COMPOUNDS, ON_COMPOUNDS, ROOM_COMPOUNDS,
PRINT_COMPOUNDS, WAY_COMPOUNDS, NORTH_POLE, NON3PRS_VERB,
IN_THE_MEAN_TIME_PHRASE, CD_NN, GAVE_GIVE, COMMA_CLOSING_PARENTHESIS
Compound-modifier hyphenation: SUBJECT_MATTER_HYPHEN, MISSING_HYPHEN,
WEEK_LONG_HYPHEN, YEAR_HYPHEN, PRP_CUSTOM_BUILD
Conversational grammar: THERE_S_MANY, THE_THIRD_PARTY,
NEITHER_NOR_SUPERFLUOUS_COMMA
Content-fixed but rule left DISABLED (FP-contaminated, same as SETUP_VERB):
OVER_COMPOUNDS — "Haggle over precise wordings" is a preposition, not a
compound. Fixed over-engineer / over-deliver / overpriced.
CYBER_COMPOUNDS — "Cyber Security Industry Alliance" is an org name.
Fixed the generic cyberterrorists / cyberattacks / cybersecurity.
Full corpus run with the new config: the 19 enabled rules produce zero hits.
(One unrelated CONFUSION_RULE_ONE_ON flag persists — an already-enabled rule,
a local-image-only FP; CI's image doesn't flag it.)
Not fixed — flagged for author: 2011-11-29-towards-a-more-agile-government.md
has "a system estimated to exceed million", a dropped dollar figure from
FAR 2.101 that needs the real number.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second evidence-driven pass over
.languagetoolrc.json, following the merged "safe slice." This tier covers rules whose hits are real errors but need a judgment call — a reword, a hyphenation house-style decision, or a case where the tool's own suggestion is wrong. Same method: full corpus run with nothing disabled, adjudicate every hit, enable only where all hits become clean.Enabled 19 rules (every hit fixed)
Bucket A — compound/agreement typos:
MAKER_COMPOUNDS(lawmakers),ON_COMPOUNDS(onboarding),ROOM_COMPOUNDS(lunchroom),PRINT_COMPOUNDS(blueprints),WAY_COMPOUNDS(halfway),NORTH_POLE(South Pole),NON3PRS_VERB(they interact),IN_THE_MEAN_TIME_PHRASE(in the meantime),CD_NN(five servers),GAVE_GIVE(I gave),COMMA_CLOSING_PARENTHESIS(stray comma).Bucket B — compound-modifier hyphenation:
SUBJECT_MATTER_HYPHEN(×6),MISSING_HYPHEN(40-page, one-hour, five-year, two-hour),WEEK_LONG_HYPHEN(day-long),YEAR_HYPHEN(ten-year),PRP_CUSTOM_BUILD(custom-build).Bucket C — conversational grammar:
THERE_S_MANY(×5, "There's two ways"→"There are two ways"),THE_THIRD_PARTY(×3, noun "a third-party"→"a third party"),NEITHER_NOR_SUPERFLUOUS_COMMA(×4, drop the comma).Content-fixed, but rule left disabled
Two bucket-B rules are FP-contaminated, so I fixed their genuine instances but kept the rule off (same discipline as
SETUP_VERB):OVER_COMPOUNDS— "Haggle over precise wordings" is a preposition, not a compound. Fixed over-engineer / over-deliver / overpriced; used hyphens (matching your "over-engineered" title), not the tool's closed forms.CYBER_COMPOUNDS— "Cyber Security Industry Alliance" is an org name. Fixed the generic cyberterrorists / cyberattacks / cybersecurity; left the proper noun.Verification
Full 195-post run with the new config: the 19 enabled rules produce zero hits. The only remaining flag is the same
CONFUSION_RULE_ONE_ONlocal-image-only false positive from the prior PR (an already-enabled rule; CI'serikvl87/languagetoolimage doesn't flag it, and its job is green onmain).src/content/posts/2011-11-29-towards-a-more-agile-government.md:507reads "a system estimated to exceed million" — a dropped dollar figure from the FAR 2.101 "major system" threshold. I left it untouched since I don't have the original number.🤖 Generated with Claude Code