test(pty): answer ConPTY queries in kill probes - #219
Merged
Conversation
the probe used to mark a DSR answered then drop a failed try_send, so Windows CI panicked before the child printed ready. retry the write, answer DA too, one ConPTY at a time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the kill tests panic on Windows CI when ConPTY's
[6nis never answered.exit_hook_probenow drives the same DSR/DA set asTerminalQueriesinsrc/lib/features/fastpick/install-output.ts, retries a failedtry_send, waits 15s, and dumps the buffer on timeout. one ConPTY at a time, via a mutex rather than--test-threads=1, so the rest of the crate stays parallel.verified locally:
cargo test -p boite-core --lib -- a_background_kill a_foreground_kill a_cursor_report a_dsr_split a_second_query colour_is_not device_attributes the_wrapped_command -- --test-threads=8(8 passed) andcargo clippy -p boite-core --all-targets -- -D warnings.