Skip to content

Add filesystem cleanup on workflow failure or cancellation - #6

Merged
beatgeek merged 5 commits into
filesystem-supportfrom
copilot/sub-pr-3
Feb 20, 2026
Merged

Add filesystem cleanup on workflow failure or cancellation#6
beatgeek merged 5 commits into
filesystem-supportfrom
copilot/sub-pr-3

Conversation

Copilot AI commented Feb 7, 2026

Copy link
Copy Markdown

Summary

  • Addresses review feedback: workflow now cleans up filesystems created during the run if deployment fails, preventing dangling Lambda Cloud resources.

Changes

  • Track whether filesystem was created (vs. reused from filesystem_id input) via filesystem_created output
  • Add cleanup step with if: (failure() || cancelled()) that deletes filesystem only when created by this workflow
  • Log deletion errors as GitHub warnings with error details for manual intervention

Testing

  • Not run (reason: workflow change validated via YAML syntax check; requires Lambda Cloud API to integration test)

Review focus

  • Conditional logic in cleanup step ensures existing user filesystems are never deleted
  • Error handling captures both API failures and connection issues

Rollout / Notes

  • Cleanup runs automatically on any workflow failure after filesystem creation step

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI and others added 4 commits February 7, 2026 23:53
Co-authored-by: beatgeek <2343225+beatgeek@users.noreply.github.com>
Co-authored-by: beatgeek <2343225+beatgeek@users.noreply.github.com>
Co-authored-by: beatgeek <2343225+beatgeek@users.noreply.github.com>
Co-authored-by: beatgeek <2343225+beatgeek@users.noreply.github.com>
Copilot AI changed the title [WIP] WIP Address feedback on Lambda filesystem support Add filesystem cleanup on workflow failure or cancellation Feb 7, 2026
Copilot AI requested a review from beatgeek February 7, 2026 23:56
@beatgeek
beatgeek marked this pull request as ready for review February 20, 2026 23:55
@beatgeek
beatgeek merged commit 2cd3b31 into filesystem-support Feb 20, 2026
3 checks passed
@beatgeek
beatgeek deleted the copilot/sub-pr-3 branch February 20, 2026 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants