Skip to content

[rpc] add initialblockdownload to getblockchaininfo#131

Open
dagurval wants to merge 1 commit into
bcoin-org:masterfrom
dagurval:ibd
Open

[rpc] add initialblockdownload to getblockchaininfo#131
dagurval wants to merge 1 commit into
bcoin-org:masterfrom
dagurval:ibd

Conversation

@dagurval

Copy link
Copy Markdown

Mimics the initialblockdownload added to getblockchaininfo in bitcoin/bitcoin#11258.

I couldn't find a IBD estimator in the bcash codebase. This is probably not a good check for IBD status, but it's only supposed to be an estimate anyway.

@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #131 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #131   +/-   ##
=======================================
  Coverage   55.55%   55.55%           
=======================================
  Files         109      109           
  Lines       27184    27184           
  Branches     4498     4498           
=======================================
  Hits        15102    15102           
  Misses      12082    12082
Impacted Files Coverage Δ
lib/node/rpc.js 22.54% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update faf1eeb...d556632. Read the comment docs.

@pinheadmz

pinheadmz commented Feb 22, 2019

Copy link
Copy Markdown
Member

<= 0.99 might be ok, but also note if there hasn't been a block in about 40 minutes, bcoin will start to show progress as < 1:

https://github.com/bcoin-org/bcoin/blob/f585d8616df8335fddbc21d1b776a979ec6ff305/lib/blockchain/chain.js#L2116-L2126

@dagurval

Copy link
Copy Markdown
Author

<= 0.99 might be ok, but also note if there hasn't been a block in about 40 minutes, bcoin will start to show progress as < 1:

https://github.com/bcoin-org/bcoin/blob/f585d8616df8335fddbc21d1b776a979ec6ff305/lib/blockchain/chain.js#L2116-L2126

I put the numbers in a sheet and as you can see this doesn't seem to be an issue.

screenshot from 2019-02-23 22-16-48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants