Repository navigation
fix(insights): count only completed phases in percent overage chart (Track-809) - #2842
Merged
Merged
Conversation
…Track-809) Not-started phases have days_taken 0, so each counted as an underage and the Trends chart showed more underages than the trends table, which already filters to completed phases. Track-808 fixed the median charts; this applies the same filter to the percent generator.
Ckoelewyn
requested review from
danieltruong,
tolkamps1 and
tom0827
as code owners
October 26, 2026 20:01
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2842 +/- ##
===========================================
+ Coverage 78.25% 82.28% +4.02%
===========================================
Files 444 336 -108
Lines 12799 12924 +125
Branches 3462 0 -3462
===========================================
+ Hits 10016 10634 +618
+ Misses 2735 2290 -445
+ Partials 48 0 -48
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
tom0827
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not-started phases have days_taken 0, so each counted as an underage and the Trends chart showed more underages than the trends table, which already filters to completed phases. Track-808 fixed the median charts; this applies the same filter to the percent generator.