Memoize computation of property references#114
Conversation
# Conflicts: # chartlets.js/packages/lib/src/actions/handleHostStoreChange.ts
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #114 +/- ##
==========================================
+ Coverage 92.53% 92.62% +0.09%
==========================================
Files 85 85
Lines 1460 1478 +18
Branches 220 222 +2
==========================================
+ Hits 1351 1369 +18
Misses 91 91
Partials 18 18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b-yogesh
left a comment
There was a problem hiding this comment.
PR looks good to me. Since we are updating the handleHostStorage.test.ts, we can also complete the TODO in one of the test? If you agree, you can add it and then merge it, if not just merge it.
Done. |
b-yogesh
left a comment
There was a problem hiding this comment.
Thank you. One suggestion, and you can merge it.
| * Relaxed requirements for adding new components to Chartlets.js via | ||
| plugins. Implementing `ComponentProps` is now optional. (#115) | ||
|
|
There was a problem hiding this comment.
Is this from another PR added by mistake here?
Closes #113