fix output softmax visualization#22
Open
jeremyschlatter wants to merge 1 commit into
Open
Conversation
For the "SM Agg" matrix at the bottom of nano-gpt, the labels were flipped from the values. That is, the row containing the max values was labeled exp, and the row containing the exp values was labeled max. The cause was that in this odin model, those rows were flipped compared to their counterparts in src/llm/GptModelLayout.ts and src/llm/GptModel.ts. Flipping them back fixes the problem. Also updates the path to native.wasm in build.sh. (build.sh got moved down a directory in 0ba3a39 "Move llm code into its own folder", but this relative path wasn't updated.) Also deletes native.wasm.o. It's not clear to me that this was intentionally committed in the first place. build.sh deleted it automatically.
|
@jeremyschlatter is attempting to deploy a commit to the Brendan's Team Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the "SM Agg" matrix at the bottom of nano-gpt, the labels were flipped from the values. That is, the row containing the max values was labeled exp, and the row containing the exp values was labeled max.
The cause was that in this odin model, those rows were flipped compared to their counterparts in src/llm/GptModelLayout.ts and src/llm/GptModel.ts. Flipping them back fixes the problem.
Before:
After:
This commit also updates the path to native.wasm in build.sh. (build.sh got moved down a directory in 0ba3a39 "Move llm code into its own folder, but this relative path wasn't updated.)
Also deletes native.wasm.o. It's not clear to me that this was intentionally committed in the first place. build.sh deleted automatically.