Skip to content

Convert minGPT and emsdk folders to git submodules#21

Open
adriandarian wants to merge 1 commit into
bbycroft:mainfrom
adriandarian:fix/submodules
Open

Convert minGPT and emsdk folders to git submodules#21
adriandarian wants to merge 1 commit into
bbycroft:mainfrom
adriandarian:fix/submodules

Conversation

@adriandarian

@adriandarian adriandarian commented Oct 14, 2025

Copy link
Copy Markdown

Overview

This pull request converts the minGPT and emsdk directories within the repository from directly included source folders to proper git submodules. This change improves maintainability, makes updates to these dependencies easier, and reduces repository bloat.

Changes

  • Removed the directly included minGPT and emsdk folders.
  • Added both projects as git submodules pointing to their respective upstream repositories.
    • minGPT submodule: [link to repo or commit, if needed]
    • emsdk submodule: [link to repo or commit, if needed]
  • Updated documentation to reflect the new submodule setup.
  • Added instructions for initializing and updating submodules in the project README.

Impact

  • Users and contributors must now initialize and update submodules after cloning:
    git submodule update --init --recursive
  • Future updates to minGPT or emsdk can be made by updating the submodule pointers and committing the change.

Motivation

  • Keeps third-party code separate from project source.
  • Simplifies dependency updates and avoids manual copying.
  • Reduces repository size and avoids duplicate version history.

Notes

  • Please ensure you run the submodule initialization command on fresh clones.
  • If you use CI/CD workflows, make sure submodule initialization is included.

- Add minGPT submodule from https://github.com/karpathy/minGPT.git
- Add emsdk submodule from https://github.com/emscripten-core/emsdk.git
- Create .gitmodules file to track submodule configurations
@vercel

vercel Bot commented Oct 14, 2025

Copy link
Copy Markdown

Someone is attempting to deploy a commit to the Brendan's Team Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant