Convert minGPT and emsdk folders to git submodules#21
Open
adriandarian wants to merge 1 commit into
Open
Conversation
- Add minGPT submodule from https://github.com/karpathy/minGPT.git - Add emsdk submodule from https://github.com/emscripten-core/emsdk.git - Create .gitmodules file to track submodule configurations
|
Someone is attempting to deploy a commit to the Brendan's Team Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This pull request converts the
minGPTandemsdkdirectories within the repository from directly included source folders to proper git submodules. This change improves maintainability, makes updates to these dependencies easier, and reduces repository bloat.Changes
minGPTandemsdkfolders.minGPTsubmodule: [link to repo or commit, if needed]emsdksubmodule: [link to repo or commit, if needed]Impact
minGPToremsdkcan be made by updating the submodule pointers and committing the change.Motivation
Notes