Skip to content

[NO TICKET] FIX: Resolve idclient assertions in e2es#13603

Merged
amoore108 merged 1 commit intolatestfrom
FIX-idclient-assertion-in-e2es
Jan 12, 2026
Merged

[NO TICKET] FIX: Resolve idclient assertions in e2es#13603
amoore108 merged 1 commit intolatestfrom
FIX-idclient-assertion-in-e2es

Conversation

@alex-magana
Copy link
Copy Markdown
Contributor

Resolves JIRA: NO TICKET

Summary

Remove spurious idclient assertions and retains the assertion that
check for the existence of the parameter.

Code changes

  • Remove idclient from assertPageView in Piano e2es.

Developer Checklist

  • UX
    • UX Criteria met (visual UX & screenreader UX)
  • Accessibility
    • Accessibility Acceptance Criteria met
    • Accessibility swarm completed
    • Component Health updated
    • P1 accessibility bugs resolved
    • P2/P3 accessibility bugs planned (if not resolved)
  • Security
    • Security issues addressed
    • Threat Model updated
  • Documentation
    • Docs updated (runbook, READMEs)
  • Testing
    • Feature tested on relevant environments
  • Comms
    • Relevant parties notified of changes

Testing

  • Manual Testing required?
    • Local (Ready-For-Test, Local)
    • Test (Ready-For-Test, Test)
    • Preview (Ready-For-Test, Preview)
    • Live (Ready-For-Test, Live)
  • Manual Testing complete?
    • Local
    • Test
    • Preview
    • Live

Additional Testing Steps

  1. List the steps required to test this PR.

Useful Links

@amoore108 amoore108 merged commit 7f966f7 into latest Jan 12, 2026
13 checks passed
@amoore108 amoore108 deleted the FIX-idclient-assertion-in-e2es branch January 12, 2026 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants