Skip to content

chore: Upgrade asm to support Java 25#409

Open
honnix wants to merge 1 commit into
bazel-contrib:mainfrom
honnix:asm-9.8
Open

chore: Upgrade asm to support Java 25#409
honnix wants to merge 1 commit into
bazel-contrib:mainfrom
honnix:asm-9.8

Conversation

@honnix
Copy link
Copy Markdown
Contributor

@honnix honnix commented Jan 27, 2026

From https://asm.ow2.io/versions.html:

29 March 2025: ASM 9.8 (tag ASM_9_8)

* new Opcodes.V25 constant for Java 25

Otherwise we are seeing errors like "Failed to transform Runtime class: Unsupported class file major version 69" in some of our tests.

@honnix
Copy link
Copy Markdown
Contributor Author

honnix commented Jan 29, 2026

@shs96c Could you please take a look at this? Thanks.

Copy link
Copy Markdown
Collaborator

@shs96c shs96c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shs96c
Copy link
Copy Markdown
Collaborator

shs96c commented Feb 17, 2026

@honnix I think that if you rebase on main and push the tests will pass. We've added some workarounds for the flakiness of the Windows builds.

@honnix
Copy link
Copy Markdown
Contributor Author

honnix commented Feb 18, 2026

@honnix I think that if you rebase on main and push the tests will pass. We've added some workarounds for the flakiness of the Windows builds.

The Windows CI is still failing.

@honnix
Copy link
Copy Markdown
Contributor Author

honnix commented Apr 29, 2026

Could you please help me with this for why Windows tests fail @shs96c ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants