Skip to content

Fix: restore default white background fallback in Button:init (app-wide crash) #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jperon wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: restore default white background fallback in Button:init (app-wide crash) #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions button.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,12 +160,22 @@ function Button:init()
self.label_widget,
}
end
local background_color, border_color, radius
if self.background then -- colored button
background_color = self.background
border_color = background_color -- without black border
radius = self.radius or Size.radius.button -- with rounded corners
else
background_color = Blitbuffer.COLOR_WHITE
radius = self.radius
end
self.frame = FrameContainer:new{
margin = self.margin,
show_parent = self.show_parent,
bordersize = self.bordersize,
background = self.background,
radius = self.radius,
background = background_color,
color = border_color,
radius = radius,
padding_top = self.padding_v,
padding_bottom = self.padding_v,
padding_left = self.padding_h,
Expand Down