feat(ecosystem): Add TypeScript types, JSDoc documentation, and accessibility improvements #2890
+277
−36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the code quality and accessibility of the Ecosystem page components by adding comprehensive TypeScript type definitions, JSDoc documentation, and accessibility enhancements.
Changes
🆕 New Files
apps/web/src/types/ecosystem.ts- Comprehensive TypeScript type definitions for:EcosystemCategory- Valid category types (ai, consumer, defi, infra, onramp, wallet)EcosystemSubcategory- Union of all valid subcategoriesEcosystemApp- Interface for ecosystem app data structureDecoratedEcosystemApp- Extended interface with search-optimized fieldsEcosystemCategoryConfig- Type for category configurationEcosystemFilterProps- Props interface for filter componentsapps/web/src/types/index.ts- Barrel export file for convenient type imports📝 Updated Files
Card.tsx- Added JSDoc documentation, uses shared types, improved accessibility with:aria-labelfor screen readersfocus-visiblering for keyboard navigationContent.tsx- Added component documentation, uses shared types with backward compatibility exportList.tsx- Added JSDoc documentation, extractedListPropsinterface, uses shared typesSearchBar.tsx- Added component documentation, extractedSearchBarPropsinterface, improved:focus-visiblering to clear button for keyboard accessibilityBenefits
Testing