Skip to content

Remove redundant comments and enforce safe TypeScript boundaries - #6

Merged
bartkozik merged 4 commits into
mainfrom
chore/remove-redundant-comments
Nov 6, 2026
Merged

bartkozik merged 4 commits into
mainfrom
chore/remove-redundant-comments

Conversation

@bartkozik

@bartkozik bartkozik commented Nov 6, 2026 •

Copy link
Copy Markdown
Owner

Unsafe JSON results in scripts and implicit application types allowed invalid values to pass typed linting. Validate report and runner inputs, type the affected application and E2E boundaries, and make explicit any and unsafe assignments, calls, arguments, returns and member access fail lint. Enable noImplicitAny and check E2E TypeScript in CI.

Also remove redundant commentary, commented-out code and historical notes. Keep required tool directives, license notices, useful type annotations and explanations of non-obvious constraints.

Validation: CI on 657ddf2 passed application/E2E typechecks, typed lint, 34 script tests, 293 unit-test files, production build, image smoke and secret checks. The TypeScript syntax scan found no explicit any in 1,024 tracked TS/TSX files. Historical GitLab-specific script tests are not included in this public CI suite.

@bartkozik
bartkozik marked this pull request as ready for review November 6, 2026 10:44
@bartkozik bartkozik changed the title Remove redundant source and test commentary Remove redundant comments and enforce safe TypeScript boundaries Nov 6, 2026
@bartkozik
bartkozik merged commit 0b3cb20 into main Nov 6, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant