Repository navigation
docs(hermes): describe the directory-plugin install the bootstrap performs - #34
Open
nir-singher-band wants to merge 1 commit into
Open
nir-singher-band wants to merge 1 commit into
nir-singher-band wants to merge 1 commit into
Conversation
…forms The guides still described the pip install into the gateway Python that bootstrap.sh stopped doing when it moved to the repo's install.sh: an editable `uv pip install --python "$hermes_python"` against a variable no script defines any more, and a Part 2 snippet resolving the skill through `import hermes_band_platform`, which a directory install cannot satisfy because the plugin is copied to $HERMES_HOME/plugins/band. State what the install does: stage the plugin into $HERMES_HOME/plugins/band, resolve band-sdk into $HERMES_HOME/band-libs with the gateway interpreter, write nothing to the gateway venv, enable the plugin. Resolve the skill by path and the interpreter with the plugin's own `gateway_python.py --print`, the way install.sh and bootstrap.sh do. Record the constraints that follow: a directory plugin is a copy, so local edits need install.sh re-run rather than an editable install; a pip copy of hermes-band overrides a directory install, which install.sh refuses; and verify_install.py reports package_importable/entry_point under `missing` on a correct directory install, so `blocking` is the field to read. Address the setup skill as `band:add-band`, matching the hand-off bootstrap.sh runs. The band plugin registers no slash command, so the previous `hermes /add-band` had nothing behind it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Follow-up to #21.
hermes/README.mdandhermes/TESTING.mdstill described the pip install into the gateway Python thatbootstrap.shstopped doing when it moved to the repo'sinstall.sh(directory plugin). Two were actively broken instructions:TESTING.mdtold you to swap inuv pip install --python "$hermes_python" -e …—$hermes_pythonis defined by no script in the repo any more.import hermes_band_platform, which a directory install cannot satisfy: the plugin is copied to$HERMES_HOME/plugins/band, not installed into the gateway venv.What changed
Both guides now state what the install actually does, per upstream
install.sh:$HERMES_HOME/plugins/band, resolveband-sdkinto$HERMES_HOME/band-libswith the gateway interpreter, write nothing to the gateway venv, enableband;gateway_python.py --print— the wayinstall.shandbootstrap.shboth do it.Constraints that follow, now recorded:
install.shre-run — there is no editable install;hermes-bandoverrides a directory install in Hermes's loader, soinstall.shrefuses to run while one is present (BAND_UNINSTALL_PIP=1removes it);verify_install.pylistspackage_importable/entry_pointundermissingon a correct directory install, soblockingis the field to read. Checklist and troubleshooting updated accordingly.uvadded to the TESTING prereqs —install.shhard-requires it foruv pip install --target.The setup skill is addressed as
band:add-band, matching the hand-offbootstrap.shruns. The previoushermes /add-bandhad nothing behind it: the band plugin registers no slash command (noregister_slash_commandin the plugin), andbootstrap.shdocuments that plugin skills never enter the flat~/.hermes/skillstree.Docs only — no change to
bootstrap.shorscripts/.Test plan
python3 scripts/check.pypytest tests/ -q(17 passed)gateway_python.pyin an installed-layout tree: resolves~/.hermes/hermes-agent/venv/bin/python, Python 3.11.15,hermes_cliimportable — matching the installer's 3.11–3.13 +hermes_clicontract.install.sh/verify_install.pyrather than the previous prose.