Skip to content

set correct paths for macos manifest installation #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
er0k wants to merge 1 commit into
base: master
Choose a base branch
from
Open

set correct paths for macos manifest installation #130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions brotab/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,15 +377,26 @@ def install_mediator(args):
if is_windows():
bt_mediator_path = make_windows_path_double_sep(bt_mediator_path)

mozilla_path = '~/.mozilla/native-messaging-hosts/'
chrome_path = '~/.config/google-chrome/NativeMessagingHosts'
chromium_path = '~/.config/chromium/NativeMessagingHosts'
brave_path = '~/.config/BraveSoftware/Brave-Browser/NativeMessagingHosts/'

if is_macos():
mozilla_path = '~/Library/Application Support/Mozilla/'
chrome_path = '~/Library/Application Support/Google/Chrome/'
chromium_path = '~/Library/Application Support/Chromium/'
brave_path = chrome_path

native_app_manifests = [
('mediator/firefox_mediator.json',
'~/.mozilla/native-messaging-hosts/brotab_mediator.json'),
f"{mozilla_path}/brotab_mediator.json"),
('mediator/chromium_mediator.json',
'~/.config/chromium/NativeMessagingHosts/brotab_mediator.json'),
f"{chromium_path}/brotab_mediator.json"),
('mediator/chromium_mediator.json',
'~/.config/google-chrome/NativeMessagingHosts/brotab_mediator.json'),
f"{chrome_path}/brotab_mediator.json"),
('mediator/chromium_mediator.json',
'~/.config/BraveSoftware/Brave-Browser/NativeMessagingHosts/brotab_mediator.json'),
f"{brave_path}/brotab_mediator.json"),
]

if args.tests:
Expand Down
2 changes: 2 additions & 0 deletions brotab/platform.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@ def register_native_manifest_windows_firefox(manifest_filename):
def is_windows() -> bool:
return platform.system() == 'Windows'

def is_macos() -> bool:
return platform.system() == 'Darwin'

def get_editor() -> str:
mapping = {
Expand Down