test(create-pr): add final validation test file#607
Merged
Conversation
added 24 commits
April 2, 2026 20:51
…dundant comments
Result: {"status":"keep","total_bytes":6268,"line_count":183,"word_count":917}
…tighten prose
Result: {"status":"keep","total_bytes":5836,"line_count":169,"word_count":844}
Not referenced by any skill or hook. Was retained for pr-pass per spec
but pr-pass doesn't actually use it.
Result: {"status":"keep","total_bytes":4534,"line_count":141,"word_count":666}
…ync when behind)
Result: {"status":"keep","total_bytes":4019,"line_count":122,"word_count":601}
Only preflight-check.sh used lib.sh. Inlining saves a file and overhead.
Result: {"status":"keep","total_bytes":3558,"line_count":107,"word_count":541}
… inline notes
Result: {"status":"keep","total_bytes":3202,"line_count":85,"word_count":490}
Result: {"status":"keep","total_bytes":3103,"line_count":82,"word_count":471}
Result: {"status":"keep","total_bytes":2884,"line_count":68,"word_count":448}
Scripts don't load into LLM context — only SKILL.md token cost matters.
Result: {"status":"keep","skill_bytes":1081,"skill_lines":27,"skill_words":151}
…edundant sections
Remove stop conditions (obvious), trim CI failure instructions,
shorten description field.
Result: {"status":"keep","skill_bytes":802,"skill_lines":23,"skill_words":110}
Result: {"status":"keep","skill_bytes":732,"skill_lines":19,"skill_words":100}
Result: {"status":"keep","skill_bytes":675,"skill_lines":18,"skill_words":93}
Result: {"status":"keep","skill_bytes":635,"skill_lines":18,"skill_words":82}
Result: {"status":"keep","skill_bytes":605,"skill_lines":17,"skill_words":82}
…r-optimize-20260402
… preflight
Test found: auto-merge is disabled after force-push, must re-enable.
Also: preflight sync push needs -u for new branches.
Result: {"status":"keep","skill_bytes":665,"skill_lines":17,"skill_words":92}
Test showed agent skipping preflight-check.sh and doing manual logic instead.
Added "Execute each line literally" + "scripts MUST be run" directive.
Result: {"status":"keep","skill_bytes":794,"skill_lines":20,"skill_words":109}
- Remove tests for deleted scripts (lib.sh, verify-pr-status.sh, sync-with-base.sh)
- Update preflight BEHIND test to expect auto-sync behavior
- Fix skill content test to accept code-block-only skills
Result: {"status":"keep","skill_bytes":794}
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (15)
📝 WalkthroughWalkthroughThis PR optimizes the Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~50 minutes Possibly related PRs
Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Summary by CodeRabbit
Bug Fixes
Documentation
Chores