Security: Potential race condition in runtime keypair materialization#486
Open
tomaioo wants to merge 1 commit into
Open
Conversation
The `materialize_runtime_signing_keypair` function checks if a key path exists and then generates a new keypair if not. This check-then-act pattern is not atomic and could lead to race conditions where multiple processes generate keypairs simultaneously, potentially causing one to overwrite the other's key. While `write_private_atomic` is used for the actual write, the existence check and generation are not atomic. Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security: Potential race condition in runtime keypair materialization
Problem
Severity:
Medium| File:apps/agent/src-tauri/src/daemon/runtime_keypair.rs:L18The
materialize_runtime_signing_keypairfunction checks if a key path exists and then generates a new keypair if not. This check-then-act pattern is not atomic and could lead to race conditions where multiple processes generate keypairs simultaneously, potentially causing one to overwrite the other's key. Whilewrite_private_atomicis used for the actual write, the existence check and generation are not atomic.Solution
Use atomic file creation with O_EXCL flag or a file-based lock to ensure only one process can create the keypair. Alternatively, always attempt to write atomically and handle the case where the file already exists.
Changes
apps/agent/src-tauri/src/daemon/runtime_keypair.rs(modified)