fix: clear stale mode publish state on tournament reload - #3898
Merged
Merged
Conversation
azumag
commented
Sep 19, 2026
azumag
left a comment
Owner
Author
There was a problem hiding this comment.
コード・設計・テスト・CI を確認しました。publicModes は tournament summary 由来のキャッシュなので、新しい load cycle の開始時に空へ戻す変更は、別 tournament の state を load failure 後まで表示し続ける問題に対する最小修正です。mode 切替は同一 tournament の一覧を共有するため依存配列に mode を追加しておらず、既存の PUT payload・retry・stale PUT abort 契約も維持されています。追加回帰テストは「旧 tournament では bm 公開済み → 新 tournament の summary が 503」を再現し、error='load' / loading=false / isPublic=false / mutation PUT なしを固定しています。HEAD 996d40c3484897839cac0cb8a82a73b621347b75 の CI #3713 と Claude Code Review #3258 はともに成功、未解決 review thread もありません。blocking 指摘なしです。
This was referenced Sep 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
publicModeswhenever a tournament summary load cycle startsThe existing mutation payload, successful load behavior, retry path, and stale PUT cancellation contract are unchanged.
Closes #3897