Skip to content

fix: clear stale mode publish state on tournament reload - #3898

Merged
azumag merged 2 commits into
mainfrom
fix/3897-reset-mode-publish-state
Sep 19, 2026
Merged

azumag merged 2 commits into
mainfrom
fix/3897-reset-mode-publish-state

Conversation

@azumag

@azumag azumag commented Sep 19, 2026

Copy link
Copy Markdown
Owner

Summary

  • clear cached publicModes whenever a tournament summary load cycle starts
  • prevent a failed load for a newly selected tournament from displaying the previous tournament's publish badge state
  • add regression coverage for published A tournament → failing B tournament transition

The existing mutation payload, successful load behavior, retry path, and stale PUT cancellation contract are unchanged.

Closes #3897

@azumag azumag left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

コード・設計・テスト・CI を確認しました。publicModes は tournament summary 由来のキャッシュなので、新しい load cycle の開始時に空へ戻す変更は、別 tournament の state を load failure 後まで表示し続ける問題に対する最小修正です。mode 切替は同一 tournament の一覧を共有するため依存配列に mode を追加しておらず、既存の PUT payload・retry・stale PUT abort 契約も維持されています。追加回帰テストは「旧 tournament では bm 公開済み → 新 tournament の summary が 503」を再現し、error='load' / loading=false / isPublic=false / mutation PUT なしを固定しています。HEAD 996d40c3484897839cac0cb8a82a73b621347b75 の CI #3713 と Claude Code Review #3258 はともに成功、未解決 review thread もありません。blocking 指摘なしです。

@azumag
azumag merged commit 93b7227 into main Sep 19, 2026
5 checks passed
@azumag
azumag deleted the fix/3897-reset-mode-publish-state branch September 19, 2026 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: tournament switch 後の mode publish 状態を前大会から持ち越さない

1 participant