-
-
Notifications
You must be signed in to change notification settings - Fork 78
Fix support for Lizard Mode #216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@General4878 can you test this? |
|
I will when I get home in a couple hours. Excited to see if it works!! |
bc32206 to
6e9f83e
Compare
6e9f83e to
253c75a
Compare
|
@ayufan built it and the problem still happens unfortunately 🙃 |
|
Give me exact steps and configs when it happens, etc.
…On Fri, 1 Aug 2025 at 20:44, General4878 ***@***.***> wrote:
*General4878* left a comment (ayufan/steam-deck-tools#216)
<#216 (comment)>
@ayufan <https://github.com/ayufan> built it and the problem still
happens unfortunately 🙃
—
Reply to this email directly, view it on GitHub
<#216 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AASOSQNOCAG4ZXZBSFNKC6T3LOYQ3AVCNFSM6AAAAACC4XZI3GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTCNBVGQ2TAMZVG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Tested with steam running/not running in the background, same result. The symptoms are the same as with the old build do you need anything else? |
|
@ayufan i see you are disabling watchdog only when lizard mouse is disabled, maybe it should always be disabled no matter the configuration of lizard mouse/buttons? |
|
Probably. Can you check this? I don’t have steam deck, so I just repurposed
kernel change.
…On Fri, 1 Aug 2025 at 21:01, General4878 ***@***.***> wrote:
*General4878* left a comment (ayufan/steam-deck-tools#216)
<#216 (comment)>
@ayufan <https://github.com/ayufan> i see you are disabling watchdog only
when lizard mouse is disabled, maybe it should always be disabled no matter
the configuration of lizard mouse/buttons?
—
Reply to this email directly, view it on GitHub
<#216 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AASOSQLQ7JZ5SBQKFUPDZYT3LO2RDAVCNFSM6AAAAACC4XZI3GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTCNBVGQ4TONZUG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@ayufan Just did. No matter if watchdog is disabled in every situation, the problem still persists. interestingly I found that if LizardButtons is enabled but LizardMouse is disabled in the SDT settings, Lizard Mouse stays enabled and it doesn’t stutter. |
|
Would you mind filling this table, or whatever columns are suitable? This would help me better understand behavior, and see what I can do:
|
|
@ayufan I will have to fill in the table tomorrow as I need to log off. But another piece of information I found which is very important: if (savedLizardButtons == LizardButtons)
{
// We need to explicitly disable lizard every some time
// but don't fight enabling it, as someone else might be taking control (Steam?)
//if (lizardButtonUpdated.AddMilliseconds(LizardModeUpdateInterval) > DateTime.Now)
return;
}I commented out the time check for the UpdateLizardButtons method, meaning the report is only sent when the LizardButtons setting is changed instead of every 250ms. And the mouse stops stuttering... It only seems to stutter when i disable LizardButtons. So I think the mouse stutter happens every time we send this report: SendFeatureByte(ID_CLEAR_DIGITAL_MAPPINGS); |
|
Interesting. We can try this as well.
…On Fri, 1 Aug 2025 at 21:48, General4878 ***@***.***> wrote:
*General4878* left a comment (ayufan/steam-deck-tools#216)
<#216 (comment)>
@ayufan <https://github.com/ayufan> I will have to fill in the table
tomorrow as I need to log off.
But another piece of information I found which is very important:
if (savedLizardButtons == LizardButtons)
{
// We need to explicitly disable lizard every some time
// but don't fight enabling it, as someone else might be taking control (Steam?)
//if (lizardButtonUpdated.AddMilliseconds(LizardModeUpdateInterval) > DateTime.Now)
return;
}
I commented out the time check for the UpdateLizardButtons method, meaning
the report is only sent when the LizardButtons setting is changed instead
of every 250ms. And the mouse stops stuttering... It only seems to stutter
when i disable LizardButtons.
So I think the mouse stutter happens every time we send this report:
SendFeatureByte(ID_CLEAR_DIGITAL_MAPPINGS);
—
Reply to this email directly, view it on GitHub
<#216 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AASOSQNBK5C3RDPKGMLQOLD3LPACDAVCNFSM6AAAAACC4XZI3GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTCNBVGYYDOMZYGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@ayufan I have tried it already, but problem is that we don’t just need to disable LizardButtons once, we need to do it every some time because steam enables it again. But every time we send ID_CLEAR_DIGITAL_MAPPINGS, it causes the mouse movement to stop, so we cannot do it constantly. Maybe there are other feature reports we can send to disable LizardButtons without sending ID_CLEAR_DIGITAL_MAPPINGS? |
|
The problem because steam enables it again is problematic. We likely have
to hide this from Steam.
…On Fri, 1 Aug 2025 at 22:11, General4878 ***@***.***> wrote:
*General4878* left a comment (ayufan/steam-deck-tools#216)
<#216 (comment)>
@ayufan <https://github.com/ayufan> I have tried it already, but problem
is that we don’t just need to disable LizardButtons once, we need to do it
every some time because steam enables it again.
But every time we send ID_CLEAR_DIGITAL_MAPPINGS, it causes the mouse
movement to stop, so we cannot do it constantly.
Maybe there are other feature reports we can send to disable LizardButtons
without sending ID_CLEAR_DIGITAL_MAPPINGS?
—
Reply to this email directly, view it on GitHub
<#216 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AASOSQIS55HLJMPMYYVFK7D3LPCVJAVCNFSM6AAAAACC4XZI3GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTCNBVGY2TQNJXGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
As per my previous comment, everything works as it should except when disabling LizardButtons with ID_CLEAR_DIGITAL_MAPPINGS which causes mouse stutter when LizardMouse is enabled. And when LizardButtons is enabled, but LizardMouse is disabled in settings, the mouse glide doesn’t seem to stop. All the problems seems to happen in the method made to change LizardButtons |
Tries to resolve: #215