chore(compat): remove dead chat_response_to_messages_response#6
Merged
Conversation
chat_response_to_messages_response and its sole consumer _ANTHROPIC_STOP_REASON_MAP have zero references in the tree (grep-confirmed, not in __all__, no dynamic use). The function was also latently buggy — it drops tool_calls and emits a text-only block — so removing it prevents accidental future wiring. Pure dead-code deletion; no behavior change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the unused
chat_response_to_messages_responsefunction and its sole consumer_ANTHROPIC_STOP_REASON_MAPfromaegisgate/adapters/openai_compat/mapper.py.Why
grepover*.py; not in any__all__; no dynamic/getattr use). The live non-streammessages←responsespath usesresponses_response_to_messages_response, not this Chat-based variant.tool_calls, and hardcodes a stop-reason map that ignorestool_calls. Leaving it invites accidental future wiring that would re-introduce a tool-loop break.Scope
Pure dead-code deletion — single file, 41 deletions, no behavior change, no interface/shape change.
Validation
grepconfirms no remaining references to either symbol.ruff check mapper.pyclean;mypy mapper.py→ Success.main. The one failing test (test_doc_alignment::test_filter_class_count_matches_docs) is pre-existing onmain(reproduced there), caused by untracked local test fixtures (DummyFilteretc.) polluting the BaseFilter subclass count when the full on-disk suite runs; it passes in isolation and is not in the CI-tracked path. Not introduced by this PR.🤖 Generated with Claude Code