Fix CCN ENS Medium - #408
Open
juan-vg wants to merge 2 commits into
Open
Conversation
added 2 commits
May 5, 2023 12:27
According to https://docs.aws.amazon.com/config/latest/developerguide/redshift-cluster-configuration-check.html this check makes no sense because 2 parameters are mandatory and they are already checked in RedshiftClusterConfigurationCheck
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I confirm these files are made available under CC0 1.0 Universal (https://creativecommons.org/publicdomain/zero/1.0/legalcode)
resolves #407
Description of changes:
RedshiftClusterConfigurationCheckcheck but Medium somehow not.RedshiftClusterConfigurationCheck2which is not present in the Security Best Practices for Redshift template, and also not present in the Low and High versions of the CCN ENS template. Moreover, theSourceIdentifieris REDSHIFT_CLUSTER_CONFIGURATION_CHECK which states that both parametersclusterDbEncryptedandloggingEnabledare mandatory. The checkRedshiftClusterConfigurationCheck2makes no sense as it's wrongly trying to check something that it's being already checked inRedshiftClusterConfigurationCheck.