Skip to content

Conversation

@feiyangliu2023
Copy link
Contributor

@feiyangliu2023 feiyangliu2023 commented Oct 15, 2025

Issue #, if available:
D322618311

Description of changes:

Description

Adds CSP (Content Security Policy) configuration validation to the build workflow for the code-editor-sagemaker-server target.

Changes

  • Added CSP validation step in .github/workflows/build-targets.yaml
  • Only executes for code-editor-sagemaker-server target

Testing

Remote

Ran build-target github action two times, before and after modifying 'patches/sagemaker/update-csp.diff', which changes CSP text.
Received one success and one failure outcome, as expected.
Link:
https://github.com/feiyangliu2023/code-editorv2/actions/runs/18529763981
https://github.com/feiyangliu2023/code-editorv2/actions/runs/18531210588

Local

Created two test scripts to verify both success and failure scenarios:
Success:

  • Applies patches for code-editor-sagemaker-server
  • Verifies CSP text exists in patched file
  • Test passes - CSP check correctly validates the configuration
    Faiure:
  • Applies patches and modifies file to remove CSP text
  • Verifies check detects missing CSP configuration
  • Test passes - CSP check correctly fails and detects the issue

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@feiyangliu2023 feiyangliu2023 marked this pull request as ready for review October 15, 2025 14:22
@feiyangliu2023 feiyangliu2023 requested a review from a team as a code owner October 15, 2025 14:22
@feiyangliu2023 feiyangliu2023 merged commit 9a706f8 into aws:main Oct 15, 2025
1 check passed
@feiyangliu2023 feiyangliu2023 deleted the csp-check branch October 29, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants