Fixing dependabot findings #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+35
to
+36
| - "[email protected]": { | ||
| - "node-addon-api": "7.1.0" |
Contributor
There was a problem hiding this comment.
What's the reason for removing this over-ride?
Contributor
Author
There was a problem hiding this comment.
If you look above in build.diff we remove kerberos, so the override is unnecessary.
| @@ -0,0 +1,75 @@ | |||
| #!/bin/bash | |||
Contributor
There was a problem hiding this comment.
Nice! Thanks for adding this script, will make our job a lot more easier the next time we want to update package-lock.json files!
sachinh-amazon
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
patches/common/build.diff.bracesdoesn't have its parent specified because while it is part of its parent package ("node_modules/findup-sync/node_modules/braces"), it isn't specified in the dependencies offindup-sync. So a global override was necessary, because npm wasn't able to recognizefindup-syncas the parent package ofbraces.package-lock.jsonoverrides (scripts/update-package-locks.sh). Works by: prepare src -> npm install -> refresh package-lock overrides -> regenerate OSS attribution.update-automation.yamlso that package-lock overrides fromnode_modulesaren't added.Testing:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.