Skip to content

Add patch to validate referer for vscode-remote-resource API (#109) #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sachinh-amazon merged 1 commit into from
Jan 2, 2026
Merged

Add patch to validate referer for vscode-remote-resource API (#109) #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions patches/sagemaker.series
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,3 +40,4 @@ sagemaker/post-startup-notifications.diff
sagemaker/sagemaker-extensions-sync.diff
sagemaker/fix-port-forwarding.diff
sagemaker/display-both-versions-in-about.diff
sagemaker/validate-http-request-referer.diff
18 changes: 18 additions & 0 deletions patches/sagemaker/validate-http-request-referer.diff
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
Index: code-editor-src/src/vs/server/node/remoteExtensionHostAgentServer.ts
===================================================================
--- code-editor-src.orig/src/vs/server/node/remoteExtensionHostAgentServer.ts
+++ code-editor-src/src/vs/server/node/remoteExtensionHostAgentServer.ts
@@ -172,6 +172,13 @@ class RemoteExtensionHostAgentServer ext
if (pathname === '/vscode-remote-resource') {
// Handle HTTP requests for resources rendered in the rich client (images, fonts, etc.)
// These resources could be files shipped with extensions or even workspace files.
+ if (req.headers.referer && req.headers.host) {
+ const parsedRefererUrl = url.parse(req.headers.referer, true);
+ if (parsedRefererUrl.host !== req.headers.host) {
+ return serveError(req, res, 403, `Forbidden.`);
+ }
+ }
+
const desiredPath = parsedUrl.query['path'];
if (typeof desiredPath !== 'string') {
return serveError(req, res, 400, `Bad request.`);