Fix Clang Compatibility and Remove Unused Variables#3728
Open
Fix Clang Compatibility and Remove Unused Variables#3728
Conversation
This commit improves compatibility with Clang on Windows and MinGW platforms by refining preprocessor conditionals that disable specific compiler warnings. The previous checks only tested for _WIN32 or __MINGW32__, but Clang on these platforms does not require the same warning suppressions, leading to unnecessary or incorrect pragma directives. Additionally, removes unused variables in OSVersionInfo.cpp and corrects the loop index type in WinHttpSyncHttpClient.cpp to use size_t instead of int. The member initialization order in WinHttpSyncHttpClient's constructor has been reordered to match the declaration order in the class definition. * Compiler warning pragmas (AwsCppSdkGTestSuite.h, EventHeader.h, GeneralHTTPCredentialsProviderTest.cpp) * Unused variable cleanup (OSVersionInfo.cpp) * Type safety improvements (WinHttpSyncHttpClient.cpp) ** Generated by CodeLite. ** Signed-off-by: Eran Ifrah <eran@codelite.org>
Contributor
|
Thanks for the update! The AWS SDK for C++ currently builds with MinGW as part of our Windows CI. Since this change adjusts preprocessor conditionals around MinGW/Clang and touches WinHttpSyncHttpClient and OSVersionInfo, I’ll run this PR through our CI to make sure it doesn’t introduce any regressions to the existing MinGW builds. |
|
Thanks for the update. I will fix the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit improves compatibility with Clang on Windows and MinGW platforms by refining preprocessor conditionals that disable specific compiler warnings. The previous checks only tested for _WIN32 or MINGW32, but Clang on these platforms does not require the same warning suppressions, leading to unnecessary or incorrect pragma directives.
Additionally, removes unused variables in OSVersionInfo.cpp and corrects the loop index type in WinHttpSyncHttpClient.cpp to use size_t instead of int. The member initialization order in WinHttpSyncHttpClient's constructor has been reordered to match the declaration order in the class definition.
NOTE: this PR is only completed when applied with this PR (to the
aws-c-commonrepo):awslabs/aws-c-common#1236
Note that this PR partially fixes: #3481 (at least the
BedrockAPI).Generated by CodeLite
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.