Crt profile credentials provider by pulimsr · Pull Request #3721 · aws/aws-sdk-cpp

pulimsr · 2026-02-12T19:32:10Z

Implementing the CRT's profile provider and removing the process provider from the default chain, also enabling the ProcessCredentials on ProfileCredentialsProvider

Check all that applies:

Did a review by yourself.
Added proper tests to cover this PR. (If tests are not applicable, explain.)
Checked if this PR is a breaking (APIs have been changed) change.
Checked if this PR will not introduce cross-platform inconsistent behavior.
Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Adding CRTProfileCredentialsProvider for CRT-based profile credential

…ofile-credentials-provider

…le provider to the default chain

merge branch 'main' of https://github.com/aws/aws-sdk-cpp into crt-profile-credentials-provider

…ofile-credentials-provider

… to ProfileCredentialsProvider

…ofile-credentials-provider

…ider from the default chain, also enabling the ProcessCredentials on ProfileCredentialsProvider

sbiscigl · 2026-02-12T19:34:19Z

src/aws-cpp-sdk-core/include/aws/core/auth/ProfileCredentialsProvider.h

   * refreshRateMs as the frequency at which the file is reparsed in milliseconds. Defaults to 5 minutes.
   */
-  ProfileCredentialsProvider(const char* profile, long refreshRateMs = REFRESH_THRESHOLD);
+  ProfileCredentialsProvider(const char* profile);


cant remove this from the public facing interface -- thats a breakign change, it just wont be passed down the impl

sbiscigl · 2026-02-12T19:34:54Z

src/aws-cpp-sdk-core/include/aws/core/auth/ProfileCredentialsProvider.h

   */
  static Aws::String GetProfileDirectory();

- protected:


cant remove this from the interface thats a breaking change, you can have it but it must do nothing

sbiscigl · 2026-02-12T19:35:28Z

src/aws-cpp-sdk-core/source/auth/ProfileCredentialsProvider.cpp

-    ReaderLockGuard guard(m_reloadLock);
-    if (!IsTimeToRefresh(m_loadFrequencyMs)) {
-      return;
+class ProfileCredentialsProvider::ProfileCredentialsProviderImp : public CrtCredentialsProvider {


public CrtCredentialsProvider

chefs kiss

sbiscigl · 2026-02-12T19:39:11Z

src/aws-cpp-sdk-core/source/auth/ProfileCredentialsProvider.cpp

+        :CrtCredentialsProvider(
+            [profile]()-> std::shared_ptr<ICredentialsProvider> {
+                CredentialsProviderProfileConfig config;
+                if (profile && profile[0] !='\0') {


do we need this validation?

removing it

sbiscigl · 2026-02-12T19:42:03Z

src/aws-cpp-sdk-core/source/auth/ProfileCredentialsProvider.cpp

+                CredentialsProviderProfileConfig config;
+                return CredentialsProvider::CreateCredentialsProviderProfile(config);
+            },
+            std::chrono::milliseconds(5000),


why 5 seconds?

… credential chain tests

…/aws/aws-sdk-cpp into crt-profile-credentials-provider

sbiscigl

2 nit comments and one rant, looks really good!

sbiscigl · 2026-02-13T15:30:32Z

src/aws-cpp-sdk-core/include/aws/core/auth/ProfileCredentialsProvider.h

 #pragma once

 #include <aws/core/Core_EXPORTS.h>
-#include <aws/core/utils/memory/stl/AWSString.h>


nit: no actual change in file so lets from it from the PR

sbiscigl · 2026-02-13T15:31:29Z

src/aws-cpp-sdk-core/source/auth/ProfileCredentialsProvider.cpp

-ProfileCredentialsProvider::ProfileCredentialsProvider(long refreshRateMs)
-    : m_impl(std::make_shared<ProfileCredentialsProviderImp>(refreshRateMs)) {}
+ProfileCredentialsProvider::ProfileCredentialsProvider(long refreshRateMs) : m_impl(std::make_shared<ProfileCredentialsProviderImp>()) {
+  (void)refreshRateMs;


nit use the macro AWS_UNREFERENCED_PARAM instead of void cast because its more accurate

sbiscigl · 2026-02-13T15:33:13Z

tests/aws-cpp-sdk-core-integration-tests/DefaultCredentialsProviderChainIntegrationTest.cpp

+protected:
+    DefaultCredentialsProviderChainIntegrationTest()
+    {
+        m_options.loggingOptions.logLevel = Aws::Utils::Logging::LogLevel::Debug;


we really aught to make this a official construct, i write this code at least times a week. not here for this PR, but something we should about. might help people use the SDK correctly better

…ofile-credentials-provider

…/aws/aws-sdk-cpp into crt-profile-credentials-provider

pulimsr added 25 commits February 3, 2026 11:56

Adding CRTProfileCredentialsProvider for CRT-based profile credential

c14eda9

Adding CRTProfileCredentialsProvider for CRT-based profile credential

Merge branch 'main' of https://github.com/aws/aws-sdk-cpp into crt-pr…

3dcacf1

…ofile-credentials-provider

Merge branch 'main' of https://github.com/aws/aws-sdk-cpp into crt-pr…

288b730

…ofile-credentials-provider

implementing the currently existing profile provider to add CRT profi…

3a600b2

…le provider to the default chain

merging from main

0d459ee

merge branch 'main' of https://github.com/aws/aws-sdk-cpp into crt-profile-credentials-provider

Merge branch 'main' of https://github.com/aws/aws-sdk-cpp into crt-pr…

5eb8769

…ofile-credentials-provider

changing names and moving functions to the pointer class

444c9d8

Merge branch 'main' into crt-profile-credentials-provider

2f38818

Deprecate ProfileConfigFileAWSCredentialsProvider and migrate callers…

da5b2f0

… to ProfileCredentialsProvider

Merge branch 'main' into crt-profile-credentials-provider

65e5eb9

using the new profile credential provider class

621afbf

removing AWS_DEPRECATED for now

00e8616

Merge branch 'main' into crt-profile-credentials-provider

69959c7

Merge branch 'main' into crt-profile-credentials-provider

233c9c0

adding missing headers

d2bca9f

Adding missing Aws::Client namespace for UserAgentFeature

ed61b12

adding namespaces

575f570

fixing missing constant declarations in ProfileCredentialsProvider

8a7967c

fixing missing constant declarations in ProfileCredentialsProvider

29b61af

adding namespace

dd2dc8e

extern variables

1b0c159

Merge branch 'main' into crt-profile-credentials-provider

01057cd

symbol collision in ProfileCredentialsProvider

bb2223e

Merge branch 'main' of https://github.com/aws/aws-sdk-cpp into crt-pr…

7fcc13a

…ofile-credentials-provider

implementing the CRT's profile provider and removing the process prov…

da860d4

…ider from the default chain, also enabling the ProcessCredentials on ProfileCredentialsProvider

sbiscigl reviewed Feb 12, 2026

View reviewed changes

pulimsr added 2 commits February 12, 2026 16:10

Merge branch 'main' into crt-profile-credentials-provider

6b650e4

Adding ProfileCredentialsProvider refresh parameter and comprehensive…

56af23d

… credential chain tests

pulimsr force-pushed the crt-profile-credentials-provider branch 2 times, most recently from 44b26f3 to 1be720c Compare February 13, 2026 13:35

Merge branch 'crt-profile-credentials-provider' of https://github.com…

a85bead

…/aws/aws-sdk-cpp into crt-profile-credentials-provider

pulimsr force-pushed the crt-profile-credentials-provider branch from 1be720c to a85bead Compare February 13, 2026 14:26

sbiscigl approved these changes Feb 13, 2026

View reviewed changes

Merge branch 'main' into crt-profile-credentials-provider

fd9f586

pulimsr force-pushed the crt-profile-credentials-provider branch 12 times, most recently from 202cd92 to 6e326d4 Compare February 17, 2026 21:54

Use AWS_UNREFERENCED_PARAM macro for unused parameters

10024fa

pulimsr force-pushed the crt-profile-credentials-provider branch from 6e326d4 to 10024fa Compare February 18, 2026 07:46

pulimsr added 6 commits February 18, 2026 04:25

Merge branch 'main' into crt-profile-credentials-provider

2daa67c

Merge branch 'main' into crt-profile-credentials-provider

2e2d619

Merge branch 'main' of https://github.com/aws/aws-sdk-cpp into crt-pr…

07b2103

…ofile-credentials-provider

Merge branch 'main' into crt-profile-credentials-provider

1971c7a

Merge branch 'crt-profile-credentials-provider' of https://github.com…

242a12b

…/aws/aws-sdk-cpp into crt-profile-credentials-provider

enabling TestChainOrderProfileProcess

9668e97

sbiscigl mentioned this pull request Feb 25, 2026

Update CRT to v0.37.3 #3730

Closed

11 tasks

pulimsr added 4 commits February 25, 2026 11:25

update crt dep

b751ac4

Merge branch 'main' into crt-profile-credentials-provider

7b63f97

Merge branch 'main' into crt-profile-credentials-provider

151ed32

Merge branch 'main' into crt-profile-credentials-provider

4a124e6

Conversation

pulimsr commented Feb 12, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sbiscigl left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants