Repository navigation
ci: run telemetry conformance through shared workflow - #1061
Merged
Merged
Conversation
hln33
added this pull request to stack #1062
October 23, 2026 01:43
hln33
force-pushed
the
ci/telemetry-conformance-workflow
branch
from
October 23, 2026 18:35
5a62f71 to
6955918
Compare
hln33
force-pushed
the
ci/telemetry-conformance-workflow
branch
from
October 23, 2026 20:27
6955918 to
85bee6f
Compare
The previous pin 21fd4c24 was the pre-rebase head of conformance PR #150. No branch reaches that commit, so GitHub can garbage-collect it. The pin also selects the runner and telemetry-extension revision the shared workflow installs. 21fd4c24 predates the exact-record golden check from conformance #160, so the green run validated the old lenient contract. Pin 3e4fdaf0, the current #150 head, whose extension matches main. Drop the feat/conformance-tests-telemetry branch filter. #1046 merged and this PR targets main. Correct the README: the shared workflow uploads reports and execution histories; CloudFormation diagnostics go to the job log.
Contributor
|
Re-pinned |
ParidelPooya
marked this pull request as ready for review
October 24, 2026 21:36
ParidelPooya
temporarily deployed
to
ai-pr-review-runtime
October 24, 2026 21:36 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
ParidelPooya
temporarily deployed
to
ai-pr-review-runtime
October 24, 2026 21:37 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
yaythomas
approved these changes
Oct 24, 2026
Codex AI reviewNo actionable findings. SDK invariants and contract tests are unchanged. Residual test risk: tests were not run, and the pinned external reusable workflow was unavailable for local inspection. Reviewed commit |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Add a telemetry conformance caller for same-repository pull requests, pushes to main, and manual runs.
Call the shared
telemetry-suite.ymlfrom aws/aws-durable-execution-conformance-tests at a pinned full SHA.Build the SDK and telemetry exporter, run the handler package tests, then bundle the handlers before deployment.
Pass the existing test-account secrets and the CodeBuild runner label.
Document the CI entry point in the package README.
Shared workflow pin
The pin is
3e4fdaf0, the head of aws/aws-durable-execution-conformance-tests#150. The pin also selects the runner and telemetry-extension revision the shared workflow installs. That revision matches conformance main, including the exact-record golden check from #160. Re-pin to the #150 merge commit after it lands.Verification
21fd4c24): telemetry-1 PASSED, 1/1 (run 40019359587). That pin predated the golden-record check, so it validated the earlier lenient contract.3e4fdaf0): telemetry-1 PASSED, 1/1, 0 uncovered, against the exact-record golden check (run 40051568060 on head96c9b7da).__tests__/templates.test.ts, includes type checking).