Repository navigation
test: cover suspended chained child in OTel - #824
Open
zhongkechen wants to merge 2 commits into
Open
zhongkechen wants to merge 2 commits into
zhongkechen wants to merge 2 commits into
Conversation
This was referenced Oct 23, 2026
zhongkechen
marked this pull request as ready for review
October 23, 2026 23:41
Contributor
Codex AI reviewNo actionable findings. Review was static: tests were not executed, and the external conformance workflow and cloud trace propagation were not validated. Reviewed commit |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The short OTel suite lacked a chained invoke whose child suspends and resumes. Add case 27 handlers in both tracing views: the child performs a one-second durable wait, resumes, and returns the original payload to its caller.
Register both caller/target pairs in the SAM template and pin the workflow to the 27-case catalog in conformance #131. Merge that shared requirement first; the Java change can then merge independently of Python #796 and JS #1068.
Validation: both local tracing-view tests pass, along with Spotless and the deployable handler bundle build. The tests compile the real handler sources, run caller and child through the public local runner, and verify suspension/resume, stable operation IDs, saved results, and child wait links. The Java local runner completes the caller's invoke with the real child result; service trace propagation is validated separately by cloud CI.