fix: cur_proxy returns typed NULL instead of Python None for CUR2→CUR1 proxy fields - #1499
Open
MohamedSherifAbdelsamiea wants to merge 1 commit into
Conversation
…1 proxy fields When building a CUR1 proxy view from CUR2 data, get_sql_expression() returned implicit Python None for fields that don't have tag/cost_category prefixes and aren't in the cur2to1_mapping. This caused Athena errors: 'Column none cannot be resolved'. Fix adds: - Lookup in cur1to2_mapping for known CUR2 equivalents - Proper product[] MAP access for product_ prefixed fields - Fallback to typed CAST(NULL AS ...) for fields with no equivalent Fixes aws-solutions-library-samples#1498
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Issue 1 from #1498.
When building a CUR1 proxy view from CUR2 data,
get_sql_expression()(line ~536-543 incid/helpers/cur_proxy.py) returned implicit PythonNonefor fields that:resource_tags_orcost_category_prefixesThis caused Athena errors:
Column 'none' cannot be resolvedFix
Added after the tag loop:
cur1to2_mappingfor known CUR2 equivalentsproduct[]MAP access for product-prefixed fieldsCAST(NULL AS ...)for fields with no equivalentTesting
cur1_proxyview creation fails withColumn 'none' cannot be resolvedcur1_proxyview created successfully with proper NULL valuesRelated