bug fixes and cmake version improvements#6
Merged
Merged
Conversation
…ion safety In Blowfish - Fix incorrect F-function byte extraction (critical bug). - Correct key-schedule handling by using `uint8_t` key bytes. - Initialize local variables in `initialize()` to prevent UB. - Improve decrypt loop and XOR usage for clarity and correctness. In Blowfish2 - Zero-initialize P-array and S-boxes to guarantee deterministic state. - Fix incorrect key size comment (448 bits, not 4224 bits). - Improve F-function byte extraction clarity. - Normalize round loop logic and use XOR-assignment. Others - Replace macro `N` with `constexpr N`. - Add `noexcept` to internal operations. - Add `initialize(const uint8_t*, size_t)` overload for binary keys. - Clean up readability and internal consistency across both ciphers. Signed-off-by: Avinal Kumar <avinal.xlvii@gmail.com>
- Increased CMake minimum version to 3.30 - added test run in github workflow Signed-off-by: Avinal Kumar <avinal.xlvii@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.