This repository was archived by the owner on May 18, 2022. It is now read-only.
Minor code refactor and test cases - #149
Open
adasari wants to merge 10 commits into
Open
Conversation
Contributor
|
This is a great start, but we should probably be revamping the APIs used in avash to use the client in AvalancheGo instead. Ex. https://github.com/ava-labs/avalanchego/blob/master/vms/avm/client.go. |
Author
@aaronbuchwald Client wrapper looks good. Shall i go ahead use client instead of explicit api calls ? if yes, what would be the output of the command(s) ? remains same or print all details of response struct ? |
Author
|
@aaronbuchwald @cgcardona - Replaced API calls with avm client for avawallet cmd and also added testcases. please take a look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.