Skip to content

Add MiniMax provider support - #434

Open
kbdevs wants to merge 1 commit into
automazeio:mainfrom
kbdevs:add-minimax-support
Open

kbdevs wants to merge 1 commit into
automazeio:mainfrom
kbdevs:add-minimax-support

Conversation

@kbdevs

@kbdevs kbdevs commented Jun 21, 2026

Copy link
Copy Markdown

Summary

  • Add MiniMax as a first-class API-key provider in Settings
  • Store minimax-*.json auth files and include them in config hot-reload fingerprints
  • Inject a managed OpenAI-compatible MiniMax provider using https://api.minimax.io/v1 with default MiniMax model aliases
  • Update provider wiring tests, verification specs, README, and Factory setup docs

MiniMax OpenAI-compatible API reference: https://platform.minimax.io/docs/api-reference/text-openai-api

Testing

  • cd src && swift test
  • make test
  • swiftc Sources/ProviderCatalog.swift Sources/CustomProviders.swift Sources/ConfigComposer.swift Verification/ConfigComposerSpec.swift -o /tmp/ConfigComposerSpec && /tmp/ConfigComposerSpec
  • swiftc Sources/ProviderCatalog.swift Sources/CustomProviders.swift Sources/ConfigComposer.swift Sources/ZAIAPIKeyStore.swift Verification/ZAIAPIKeyStoreSpec.swift -o /tmp/ZAIAPIKeyStoreSpec && /tmp/ZAIAPIKeyStoreSpec
  • swiftc Sources/ConfigInputFingerprint.swift Verification/ConfigInputFingerprintSpec.swift -o /tmp/ConfigInputFingerprintSpec && /tmp/ConfigInputFingerprintSpec
  • git diff --check

Note: swift test still emits the existing AppDelegate.windowDidClose / windowDidExpose warning unrelated to this change.

@ranaroussi

Copy link
Copy Markdown
Member

Reviewed. This is the right shape for a provider addition. Specifically:

  • Generalizing ZAIAPIKeyStore into a shared managed-provider store instead of copy-pasting it is the change I would have asked for.
  • It routes through the existing ConfigComposer managed-provider path rather than inventing a parallel one, and it respects the enable/disable and fingerprint/hot-reload machinery.
  • Tests and verification specs are updated alongside, plus README and FACTORY_SETUP.

Two items before merge:

  1. Please confirm https://api.minimax.io/v1 and the eight MiniMax-M* model IDs are current. As with any managed provider, a stale model name just 404s for users.
  2. Merge order: feat(menu): add Claude and Codex usage controls #485 moves src/Verification/*Spec.swift into XCTest targets and deletes those files. Your changes touch ConfigComposerSpec, ConfigInputFingerprintSpec, and ZAIAPIKeyStoreSpec, so whichever lands second needs a rebase. My intent is to land this one first so you do not have to redo the work against deleted files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants