Repository navigation
Conversation
Turn reflection saved "respond in Portuguese" as a user memory, and English added no language instruction, so that memory silently overrode ui.locale = en. State the configured language for every locale, make it override remembered language preferences, and never save reply-language memories.
Contributor
Author
|
Landed on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Models replied in Brazilian Portuguese for a user whose
ui.localeisen. Turn reflection had saved the user memory "Igor communicates in Portuguese; respond in Portuguese by default…", andbuildLocaleInstruction('en')returned an empty string, so the memory was the only language guidance in the prompt.Change
buildLocaleInstructionstates the configured language for every locale, English included, and says it overrides any remembered language preference.language/localeor phrased as "respond/reply/communicate … in ".Verification
tsc --noEmitclean. Full suite: 13957 pass; 5 failures in compiled-binary and FeedbackSurveyLine tests fail identically without this change.Existing bad memories stay on disk; with this change they no longer override the configured language.