-
Notifications
You must be signed in to change notification settings - Fork 19
feat: NotificationService #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
feat: NotificationService #63
Conversation
c08db89 to
7ae9121
Compare
7cb59b2 to
b19a575
Compare
…fyList()` methods, `NotificationService.java` interface javadocs
|
I have a blocker with the last 2 outstanding tasks to merge this PR. They are related to validating the NotificationParams object. In my opinion, I think it is okay to ignore for now because the only work that is left is validating the NotificationParams object. Notifications still work in this PR. I've left comments and the ground work is laid out in case we really want to add Notification validation in the future. If you think this PR is okay, it is good to merge. More Info on the Issue:Unable to implement the use of static method The summary of the problem is that the method requires the RootURL of the atDirectory server but the Sources:
|
|
Branch has merge conflicts that need to be resolved |
Change Log
AtClienthas agetNotificationServicemethod to get theNotificationServiceinstance that is instantiated in the constructor ofAtClientImplAtClientValidation.javahas a new methodvalidateNotificationRequest(NotificationParams, String rootDomain, int rootPort)common/, we haveNotificationEnums.javawhich has enums used by Notifications.NotifyListResponseTransformerthat transforms a response from running the verbnotify:listinto usable Java objectsNotificationStatusVerbBuildertoNotifyStatusVerbBuilderapi/notification/directory which contains the following:AtNotification.java- object represents an AtNotificationNotificationParams.java- object to enter inside of thenotifymethodNotificationResult.java- object returned upon using NotificationService methods that holds information after executing said method.NotificationService.java- interface defining functions to be implemented by ImplNotificationServiceImpl.java- implementation of Notificationnotify:listinput creates a desired output)Not Done
AtClientValidationTest.javavalidateNotificationRequestis not used by NotificationServiceImpl and untestedUsage
See
NotifyListExample.java,NotifyRemoveExample.java, andNotifySendExample.javafor usage examples.closes #6