fix: use after_initialize instead of to_prepare for patch loading - #5
Draft
ciremoussadia wants to merge 2 commits into
Draft
fix: use after_initialize instead of to_prepare for patch loading#5ciremoussadia wants to merge 2 commits into
ciremoussadia wants to merge 2 commits into
Conversation
ciremoussadia
force-pushed
the
6.1-migration
branch
from
July 23, 2026 08:52
6f95ac5 to
9678435
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rails.configuration.to_prepare never actually fired for this plugin's prepends in this app (Query/IssueQuery never got RedmineWorkflowHiddenFields patched in, verified via IssueQuery.ancestors on a fresh boot), while the sibling z_sante plugin's identical prepend pattern under RedmineApp::Application.config.after_initialize works reliably. Switching to the same after_initialize hook fixes it. Unrelated to the Redmine 6.1 bump itself; found incidentally while smoke-testing it.