build(deps): replace monstrs runtime packages - #216
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2aa29fa6ea
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b14390aa6d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| type: command.type, | ||
| }) | ||
| const { url, fields } = await this.signedUrlSigner.generateWriteUrl( | ||
| process.env.GCS_BUCKET, |
There was a problem hiding this comment.
When the files service runs under the checked-in docker-compose local stack, GCS_BUCKET=${GCS_BUCKET} is empty unless the developer exports it, while the only default bucket still provided there is FILES_BUCKET=dev. This new call now passes that empty process.env.GCS_BUCKET directly to the signer, so the default local upload flow reaches GCS signing with no bucket name and fails before clients can upload; either preserve the existing bucket fallback or update the compose/env defaults alongside this switch.
Useful? React with 👍 / 👎.
1 participant
Таска
Как проверять
До фикса
Действие: проверить manifests и lock на
@monstrs/nestjs-signed-url,@monstrs/oathkeeper-auth,@monstrs/nestjs-elasticsearch-indicator.Ожидаемый результат: старые runtime-пакеты
@monstrsприсутствуют в контуре и удерживают legacy-зависимости.После фикса
Контекст: runtime dependency cleanup для оставшихся
@monstrsпакетов.Действие: проверить manifests,
.yarnrc.yml,yarn.lockи PnP после перехода на ATLS Ory/Signed URL пакеты.Ожидаемый результат:
@monstrs/nestjs-signed-url,@monstrs/oathkeeper-authи@monstrs/nestjs-elasticsearch-indicatorотсутствуют в runtime manifests и lock.Контекст: затронутые workspace после замены зависимостей.
Действие: собрать
@files/service,@public-gateway/app,@search/service,@site/renderer-entrypointштатными Yarn/Raijin командами.Ожидаемый результат: все четыре workspace собираются без прямых обходных запусков.
Пруфы
yarn install --immutable: проходитgit diff --check: проходитrg -n "@monstrs/(nestjs-signed-url|nestjs-elasticsearch-indicator|oathkeeper-auth)|@monstrs/oathkeeper-auth|@monstrs/nestjs-signed-url|@monstrs/nestjs-elasticsearch-indicator" files search public-gateway site package.json .yarnrc.yml yarn.lock -S: matches отсутствуютyarn workspace @files/service build: проходитyarn workspace @public-gateway/app build: проходитyarn workspace @search/service build: проходитyarn workspace @site/renderer-entrypoint build: проходитyarn check: завершается с exit0; нерелевантный formatter output откачен из PR