Skip to content

feat(raijin): apply assembly dispositions - #897

Merged
TorinAsakura merged 3 commits into
pre-v3/architecture-foundationfrom
feat/raijin-assembly
Aug 17, 2026
Merged

feat(raijin): apply assembly dispositions#897
TorinAsakura merged 3 commits into
pre-v3/architecture-foundationfrom
feat/raijin-assembly

Conversation

@TorinAsakura

@TorinAsakura TorinAsakura commented Aug 13, 2026

Copy link
Copy Markdown
Member

Task

How to verify

Main scenario

  1. Context: A Raijin checkout uses the checked .yarn/releases/yarn.mjs under the repository PnP/ESM configuration.
    Action: Build the private assembly and invoke the checked runtime through the repository Yarn entrypoint.
    Expected result: Yarn reports 4.14.1; all 38 accepted commands remain available from 44 bundled plugins.

  2. Context: The private assembly has no source-development or package-publish lifecycle.
    Action: Run two clean yarn cli:build operations.
    Expected result: Both builds materialize byte-identical runtime files and regenerate metadata from the checked artifact.

Retained patch proofs

dynamic-require.mjs

  • Unpatched reproduction: canonical build reaches checked-runtime metadata generation and fails in dynamicRequireNoCache with TypeError: Cannot read properties of undefined (reading 'indexOf').
  • Supported consumer: yarn raijin:generate executed by the checked PnP/ESM runtime during materialization.
  • Match contract: source 1, replacement 0 before patch; source 0, replacement 1 after patch.
  • Removal gate: a released pinned Yarn dependency handles a missing module.children, and the unpatched canonical build plus metadata route passes.

nbind.mjs

  • Unpatched reproduction: the canonical bundle builds, but standalone runtime --version fails with ReferenceError: _a is not defined in the legacy nbind payload.
  • Supported consumer: standalone checked runtime startup and both repository PnP/ESM consumers.
  • Match contract: source 1, replacement 0 before patch; source 0, replacement 1 after patch.
  • Removal gate: the bundled UI contour moves from Ink 3 / yoga-layout-prebuilt to a released Ink version using the maintained Yoga mechanism, and the unpatched canonical runtime route passes.

The former .cjs to .mjs patch is removed; runtime filename/update ownership remains with #842.

Proofs

  • yarn cli:build, twice:
first canonical build:  2dd2544d39bafb4711ef8145a44a5c537e648063c590a1c8c5743b726008055e
second canonical build: 2dd2544d39bafb4711ef8145a44a5c537e648063c590a1c8c5743b726008055e
.yarn/releases/yarn.mjs: 2dd2544d39bafb4711ef8145a44a5c537e648063c590a1c8c5743b726008055e
exit status: 0 for both builds
  • Checked runtime inventory:
Yarn version: 4.14.1
Commands: 38
Plugins: 44
  • yarn raijin:smoke:cli:
Disposable surface PnP consumer passed (4.14.1)
Disposable project-generation PnP consumer passed (4.14.1)
exit status: 0

@TorinAsakura TorinAsakura self-assigned this Aug 13, 2026
@TorinAsakura TorinAsakura changed the title [Feature] Apply the accepted Raijin assembly dispositions feat(raijin): apply assembly dispositions Aug 13, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 17537f592b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread yarn/cli/src/plugins/getPluginConfiguration.ts
@TorinAsakura
TorinAsakura merged commit 5a462d0 into pre-v3/architecture-foundation Aug 17, 2026
10 of 13 checks passed
@TorinAsakura
TorinAsakura deleted the feat/raijin-assembly branch August 17, 2026 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant