Skip to content

fix(grpc-error-status): decode google rpc status details - #11

Merged
TorinAsakura merged 5 commits into
masterfrom
build/upgrade-raijin-grpc-error-status
Jun 30, 2026
Merged

fix(grpc-error-status): decode google rpc status details#11
TorinAsakura merged 5 commits into
masterfrom
build/upgrade-raijin-grpc-error-status

Conversation

@TorinAsakura

@TorinAsakura TorinAsakura commented Jun 30, 2026

Copy link
Copy Markdown
Member

Таска

Как проверять

До фикса

  1. Контекст: @atls/grpc-error-status в ESM/PnP-потребителе
    Действие: импортировать публичную точку входа и декодировать grpc-status-details-bin с google.rpc.BadRequest
    Ожидаемый результат: До фикса: импорт падает на exports сгенерированного proto, а декодированные details не содержат fieldViolationsList с field и description

После фикса

  1. Контекст: @atls/grpc-error-status после Raijin upgrade
    Действие: импортировать публичную точку входа и декодировать grpc-status-details-bin с google.rpc.BadRequest и full type URL
    Ожидаемый результат: После фикса: публичная точка входа импортируется, ErrorStatus.fromServiceError и getErrorStatusDetails возвращают полный BadRequest detail

Пруфы

  • yarn check
passed
  • yarn check packages/grpc-error-status
passed
  • yarn test unit error-status
4 Pass / 0 Fail / 1 Files
  • yarn workspace @atls/grpc-error-status build
passed

@TorinAsakura TorinAsakura self-assigned this Jun 30, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 73bc51edef

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/grpc-error-status/proto/package.json
Comment thread packages/grpc-error-status/src/google.rpc.ts Outdated
Comment thread packages/grpc-error-status/src/index.ts Outdated
Comment thread packages/grpc-error-status/src/status-details.ts Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d56dc7682a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/grpc-error-status/src/proto.ts
Comment thread packages/grpc-error-status/src/proto.ts
@TorinAsakura
TorinAsakura merged commit 6788971 into master Jun 30, 2026
6 checks passed
@TorinAsakura
TorinAsakura deleted the build/upgrade-raijin-grpc-error-status branch June 30, 2026 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant