Fix dropdown multiple JSON

demos/_unit-test/dropdown-html.php

@@ -49,6 +49,13 @@
     'dropdownOptions' => ['allowAdditions' => true],
 ]);
 
+$form->addControl('dropdown_multi_json', [
+    Form\Control\Dropdown::class,
+    'caption' => 'Dropdown multiple JSON',
+    'multiple' => true,
+    'values' => $htmlValues,
+], ['type' => 'json']);
+
 $lookupModel = new Model();
 $lookupModel->addField('id', ['type' => 'string']);
 $lookupModel->addField('name', ['type' => 'string']);
@@ -83,16 +90,35 @@
     'multiple' => true,
     'model' => $lookupModel,
     'settings' => ['allowAdditions' => true],
-]); */
+]);
+
+$form->addControl('lookup_multi_json', [
+    Form\Control\Lookup::class,
+    'caption' => 'Lookup multiple JSON',
+    'multiple' => true,
+    'model' => $lookupModel,
+]/* , ['type' => 'json'] *-/);
+$form->entity->getField('lookup_multi_json')->type = 'json'; */
 
 foreach (array_keys($form->entity->getFields()) as $k) {
-    $form->entity->set($k, $makeTestStringFx('d'));
+    $form->entity->set(
+        $k,
+        str_contains($k, 'json')
+            ? [$makeTestStringFx('d')]
+            : $makeTestStringFx('d')
+    );
 }
 
 $initData = $form->entity->get();
 
 $form->onSubmit(static function (Form $form) use ($app, $initData, $makeTestStringFx) {
-    $makeExpectedDataFx = static fn ($fx) => array_map(static fn ($k) => $fx($k), array_combine(array_keys($initData), array_keys($initData)));
+    $makeExpectedDataFx = static fn ($fx) => array_map(static function ($k) use ($fx) {
+        $res = $fx($k);
+
+        return str_contains($k, 'json')
+            ? explode(',', $res)
+            : $res;
+    }, array_combine(array_keys($initData), array_keys($initData)));
 
     // TODO remove once https://github.com/fomantic/Fomantic-UI/pull/3205 is merged
     foreach ($form->entity->get() as $k => $v) {
@@ -104,7 +130,7 @@
     $view->invokeInit();
     $view->text->addParagraph($app->encodeJson($form->entity->get()));
     $view->text->addParagraph('match init: ' . ($form->entity->get() === $initData));
-    $view->text->addParagraph('match u add: ' . ($form->entity->get() === $makeExpectedDataFx(static fn ($k) => (str_contains($k, 'multi') ? $initData[$k] . ',' : '') . $makeTestStringFx('u'))));
+    $view->text->addParagraph('match u add: ' . ($form->entity->get() === $makeExpectedDataFx(static fn ($k) => (str_contains($k, 'multi') ? $makeTestStringFx('d') . ',' : '') . $makeTestStringFx('u'))));
     $view->text->addParagraph('match empty: ' . ($form->entity->get() === $makeExpectedDataFx(static fn () => '')));
     $view->text->addParagraph('match u only: ' . ($form->entity->get() === $makeExpectedDataFx(static fn () => $makeTestStringFx('u'))));
 

js/src/VueComponent/Multiline/MultilineRowComponent.js

@@ -3,10 +3,9 @@ import MultilineCell from './MultilineCellComponent';
 
 /**
  * This will create a table td element using SuiTableCell.
- * The td element is created only if column as set isVisible = true;
+ * The td element is created only if column as set isVisible = true.
  * The td element will add a multiline cell element.
- * the multiline cell will set it's own template component depending on the fieldType.
- * getValue
+ * The multiline cell will set it's own template component depending on the fieldType.
  */
 export default {
     name: 'AtkMultilineRow',

src/Form.php

@@ -13,7 +13,6 @@
 use Atk4\Data\Reference\ContainsMany;
 use Atk4\Data\ValidationException;
 use Atk4\Ui\Form\Control;
-use Atk4\Ui\Js\Jquery;
 use Atk4\Ui\Js\JsBlock;
 use Atk4\Ui\Js\JsChain;
 use Atk4\Ui\Js\JsConditionalForm;
@@ -453,6 +452,10 @@ protected function loadPost(): void
 
                 try {
                     if ($control instanceof Control\Dropdown || $control instanceof Control\Lookup || $control instanceof Control\Radio) { // this condition is definitely unacceptable, also should Control::set() be in the catch?
+                        if (($control instanceof Control\Dropdown || $control instanceof Control\Lookup) && $control->multiple && $control->entityField->getField()->type === 'json') {
+                            $postRawValue = $this->getApp()->encodeJson(explode(',', $postRawValue));
+                        }
+
                         $control->set($this->getApp()->uiPersistence->typecastAttributeLoadField($control->entityField->getField(), $postRawValue));
                     } else {
                         $control->set($this->getApp()->uiPersistence->typecastLoadField($control->entityField->getField(), $postRawValue));

src/Form/Control/Dropdown.php

@@ -110,20 +110,10 @@ public function getValue()
         return $this->entityField !== null
             ? ($this->multiple && $this->entityField->getField()->type === 'json' && is_array($this->entityField->get())
                 ? implode(', ', $this->entityField->get())
-                : $this->entityField->get())
+                : $this->getApp()->uiPersistence->typecastAttributeSaveField($this->entityField->getField(), $this->entityField->get()))
             : parent::getValue();
     }
 
-    #[\Override]
-    public function set($value = null)
-    {
-        if ($this->multiple && $this->entityField !== null && $this->entityField->getField()->type === 'json' && is_string($value)) {
-            $value = explode(',', $value);
-        }
-
-        return parent::set($value);
-    }
-
     /**
      * Set JS dropdown() specific option;.
      *

src/Form/Control/Lookup.php

@@ -143,9 +143,12 @@ protected function init(): void
     #[\Override]
     public function getValue()
     {
+        // dropdown input tag accepts CSV formatted list of IDs
         return $this->entityField !== null
-            ? $this->getApp()->uiPersistence->typecastAttributeSaveField($this->entityField->getField(), $this->entityField->get())
-            : ($this->content ?? '');
+            ? ($this->multiple && $this->entityField->getField()->type === 'json' && is_array($this->entityField->get())
+                ? implode(', ', $this->entityField->get())
+                : $this->getApp()->uiPersistence->typecastAttributeSaveField($this->entityField->getField(), $this->entityField->get()))
+            : parent::getValue();
     }
 
     /**

tests-behat/dropdown.feature

@@ -34,20 +34,23 @@ Feature: Dropdown
     When I select "uTitle <b>\"' &lt;" in lookup "dropdown_single2"
     When I select "uTitle <b>\"' &lt;" in lookup "dropdown_multi"
     When I select "uTitle <b>\"' &lt;" in lookup "dropdown_multi2"
+    When I select "uTitle <b>\"' &lt;" in lookup "dropdown_multi_json"
     When I press button "Save"
     Then Modal is open with text "match u add: 1"
     When I click close modal
     When I select "" in lookup "dropdown_single"
     When I select "" in lookup "dropdown_single2"
     When I select "" in lookup "dropdown_multi"
     When I select "" in lookup "dropdown_multi2"
+    When I select "" in lookup "dropdown_multi_json"
     When I press button "Save"
     Then Modal is open with text "match empty: 1"
     When I click close modal
     When I select "uTitle <b>\"' &lt;" in lookup "dropdown_single"
     When I select "uTitle <b>\"' &lt;" in lookup "dropdown_single2"
     When I select "uTitle <b>\"' &lt;" in lookup "dropdown_multi"
     When I select "uTitle <b>\"' &lt;" in lookup "dropdown_multi2"
+    When I select "uTitle <b>\"' &lt;" in lookup "dropdown_multi_json"
     When I press button "Save"
     Then Modal is open with text "match u only: 1"