ci: add workflow to verify generated docs are up to date#2096
Conversation
|
What reviewer looks at during PR reviewThe following are ideal points maintainers look for during review. Reviewing these points yourself beforehand can help streamline the review process and reduce time to merge.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR adds a GitHub Actions workflow to verify generated documentation stays up-to-date in PRs, and updates the docs generation script to call ChangesDocumentation Verification & Generation
🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/update-docs-up-to-date.yml:
- Around line 33-35: Replace the floating ref
"asyncapi/.github/.github/actions/get-node-version-from-package-lock@master"
with an immutable commit SHA: locate the uses line (id: lockversion) and change
the tail "`@master`" to a specific commit hash (e.g. "@<commit-sha>") obtained
from the asyncapi/.github repo to pin the action; apply the same change for
other workflows that reference this action to ensure reproducible runs.
In `@apps/react-sdk/package.json`:
- Around line 61-62: Add a top-level "engines" field to the package.json for
apps/react-sdk specifying Node and npm version constraints; update the
package.json (same object that contains keys like "name", "version", and
"scripts") to include "engines": { "node": ">=24.11", "npm": ">=11.5.1" } so
tooling and CI enforce Node >=24.11 and npm >=11.5.1.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 5fae166d-5d2f-4ca4-9ac2-f7595cb58c75
📒 Files selected for processing (2)
.github/workflows/update-docs-up-to-date.ymlapps/react-sdk/package.json
|



Description
Adds a CI check that regenerates docs on every PR and fails if the committed API.md files drift from their sources. Also fixes the react-sdk docs script to use sequential execution (&&) instead of parallel (&) and to resolve jsdoc2md via PATH rather than a hardcoded node_modules path, which was causing the regeneration to silently produce stale output on some environments.
Related issue(s)
Fixes #2038
Summary by CodeRabbit