Fix shader code and add webgl flush#17
Open
maeneak wants to merge 1 commit intoastrosat:masterfrom
maeneak:ios-bugfix
Open
Fix shader code and add webgl flush#17maeneak wants to merge 1 commit intoastrosat:masterfrom maeneak:ios-bugfix
maeneak wants to merge 1 commit intoastrosat:masterfrom
maeneak:ios-bugfix
Conversation
Contributor
Not really, just being paranoid about mutating stuff that shouldn't be. |
Author
|
You may be able to find a more elegant way to do the |
|
As far as I can see, these are relevant and localized changes. Probably not tested in a while, but can this perhaps just be merged? The original branch is gone, it seems, and it would be too bad to lose this fix. We can give it a spin and report back, if this gets merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code changes to fix floating point bug from #12 and reduce particle flickering on mobile browsers. I've also added a small update to
particle.jsfor 2 random DOMMatrix definitions not using thewindowobject which were blocking the use of polyfills for browsers that dont support the Geometry Interfaces spec (edge desktop etc.). The use of DOMMatrixReadOnly inutil.jsalso blocks this and replacing it with DOMMatrix tests fine, is there any benifit in using DOMMatrixReadOnly?