Implement support for targets defined by TLE (Two-Line Element set) #566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelbaisch
force-pushed
the
tle_target
branch
from
19438a1 to
b9e9352
Compare
Contributor
Author
|
I've resolved the conflicts and fixed my tests. Is there anything missing that would prevent this from being merged? |
* Add TLETarget class that uses skyfield internally to return RA/Dec values for specific times * The get_skycoord() function now takes a 'time' argument because the returned SkyCoord RA/Dec values are time-dependent for TLETargets * get_skycoord() behavior for non-TLETargets and multiple times can be controlled with the 'backwards_compatible' argument * Only perform 'grid_times_targets' when targets and times are not broadcastable * Update the schedule table so it also displays sensible info for TLETargets * Update Tests
… atmospheric refraction in `ICRF.altaz()` - Update tests with an example without an observer and one with temperature and pressure. Also, use time above the horizon to test `TLETarget.altaz()`, and test `TLETarget.altaz()` with multiple times. - Use `@pytest.mark.remote_data` for TLE tests since they use `Observer.at_site()`.
michaelbaisch
force-pushed
the
tle_target
branch
from
b9e9352 to
4c43d3d
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #566 +/- ##
==========================================
+ Coverage 72.90% 73.91% +1.01%
==========================================
Files 14 14
Lines 1849 1936 +87
==========================================
+ Hits 1348 1431 +83
- Misses 501 505 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #565
For get_skycoord(), I opted for the backwards compatibility option by default. There are more details in the code, but the basic question is: Do we want to be 100% backwards compatible, or do we prefer consistent output? Having said that, everything that I've tested works well like this.
The new table looks like this: