Rename Dockerfile workdir - #11
Open
Vminoz wants to merge 1 commit into
Open
Conversation
zanieb
reviewed
Nov 16, 2025
Comment on lines
+13
to
+17
| # Add created venv binaries to PATH | ||
| ENV PATH="/server/.venv/bin/:$PATH" | ||
|
|
||
| # Run the application. | ||
| CMD ["/app/.venv/bin/fastapi", "run", "app/main.py", "--port", "80"] | ||
| CMD ["fastapi", "run", "app/main.py", "--port", "80"] |
Member
There was a problem hiding this comment.
Should we be changing this part? (I don't have strong feelings, but curious for the motivation)
Author
There was a problem hiding this comment.
It aligns with https://github.com/astral-sh/uv-docker-example/blob/main/Dockerfile and I suppose resolves #1
zanieb
reviewed
Nov 16, 2025
|
|
||
| # Copy the application into the container. | ||
| COPY . /app | ||
| COPY . /server |
Member
There was a problem hiding this comment.
Is there a best-practice name people use? /repo maybe?
Author
There was a problem hiding this comment.
Usually /app 😄
But I've seen some images use /srv/some-name which I suppose is FHS-compliant although that's not a big deal for Docker containers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up on astral-sh/uv#16701
The fact that the main module of the app is at
/app/app/main.pyseems to have caused some confusion.Would need an update in the related docs too.