feat(skill): vendor mode — materialize installed skills as committed files

[raks097]

Adds a --vendor install mode and unifies --local through the Materializer seam. Targeted for v0.28.0 (must land before the release bump #262).

What

• --vendor (qvr add <skill> --vendor, qvr add --local <path> --vendor): materializes the skill as real, committed files — a real directory at the canonical target, sibling targets as relative symlinks — instead of a symlink into the global store. This is the only mode where a skill travels with a git clone: no store, no registry, no qvr needed to read it. Verified end-to-end (wiped the entire store; vendored files persisted; qvr sync reconciled cleanly).
• --local via the Materializer seam: the bespoke copyDir in both the install and sync-restore paths now flows through Materializer.MaterializeFromDisk → the reflink/content-store BlobMaterializer, skipping exactly what the canonical hasher excludes so the copy hash-agrees. qvr lock verify --strict passes on a plain --local install and after a store-wipe + sync.
• ModeVendor mirrors ModeEdit across reconcile / remove / cache-prune / edit-guard; vendoring reuses the qvr edit eject machinery (shared copyTreeToCanonical with an initNestedRepo flag).

Verification

• New internal/skill/vendor_test.go: local vendor, registry vendor (provenance + hash preserved), multi-target relative siblings, travels-without-store, remove-without-force, edit-refuses-vendored — all pass.
• make all green (fmt + lint + test + build); gocyclo clean (≤15 — extracted linkLocalTargets to keep InstallLocal under); golangci-lint 0 issues; modernize clean.
• Real-binary smoke tests of every path.

Review-only — please merge manually (and before #262 so v0.28.0 ships with it).

[greptile-apps]

Confidence Score: 5/5

All four rollback holes flagged in prior rounds are correctly plugged; the feature logic is well-tested and the existing suite passes.

The vendor flow — materialize, promote, repoint siblings, finalize entry, write lock — handles every failure mode with the appropriate rollback or RemoveAll guard, matching the prior EjectToTarget pattern. The MaterializeFromDisk path correctly unifies exec-bit handling and .git/signature exclusion with the canonical hasher. The single finding is a stale 'eject' prefix in a shared error message, which has no functional impact.

No files require special attention beyond the minor error-message nit in internal/skill/eject.go.

Important Files Changed

Filename	Overview
internal/skill/eject.go	Adds VendorIntoRepo and refactors materializeEjectDir into the shared copyTreeToCanonical/promoteStagingOntoCanonical helpers; rollback on repointSiblingTargets failure mirrors EjectToTarget. One style nit: the 'eject …' prefix in repointSiblingTargets's error message is now stale now that the function is shared with the vendor path.
internal/skill/installer.go	Adds Vendor field to InstallRequest, wires VendorIntoRepo post-install in both InstallInto and InstallLocal, and adds rollbackInstallResult/rollbackVendoredInstall to clean up the vendor dir on lock.Write() failure. All four previously-flagged rollback holes are now plugged.
internal/skill/materialize.go	Adds MaterializeFromDisk and writeDiskEntry to the Materializer, replacing bespoke copyDir calls for local installs. Symlink escape checks correctly handle the bare '..' case. Exec-bit and exclusion logic mirrors the canonical hasher.
internal/skill/reconciler.go	Adds ModeVendor handling via the new reconcileInRepoEntry helper, reused for both edit and vendor modes. restoreLocal now delegates to Installer.materializeLocalCopy through the Materializer seam; the nil-Installer guard is safe given NewReconciler is the only non-test constructor.
internal/model/lockfile.go	Adds ModeVendor constant and VendorPath field to LockEntry, with IsVendor() accessor mirroring IsEdit(). Backward-compatible via omitempty.
internal/skill/linker.go	Adds IsVendor() branch to EffectiveTarget, correctly resolving project-relative VendorPath against projectRoot and passing through absolute paths for global scope.
internal/skill/vendor_test.go	New test file covering local vendor, registry vendor, multi-target relative siblings, travels-without-store, remove, and edit-refusal; also covers the symlink-escape fix via TestMaterializeFromDisk_RefusesEscapingSymlink.
cmd/add.go	Adds --vendor flag, wires it into addInstallItem and runAddLocal, and adds a --vendor && --frozen validation guard. skillDirForEntry is patched to handle the empty-worktree case for vendor/edit/link modes.
cmd/edit.go	Adds an early guard in ejectUnderLock that returns a clear user-facing error when qvr edit is run on a vendored skill instead of producing a confusing clobber failure.
internal/registry/path.go	Returns empty string from WorktreePathForEntry for vendor entries, letting qvr cache prune treat the transient store worktree as orphanable. Correctly documented with rationale.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["qvr add skill --vendor"] --> B[InstallInto / InstallLocal]
    B --> C[Resolve + scan + store materialize]
    C --> D[linkInstallTargets\ncreates symlinks]
    D --> E[lock.Put entry]
    E --> F{req.Vendor?}
    F -->|No| G[lock.Write\nmode:shared]
    F -->|Yes| H[VendorIntoRepo]
    H --> I[copyTreeToCanonical\ninitNestedRepo=false]
    I --> J[copyDir source to staging]
    J --> K[setSubtreeWritable staging]
    K --> L[promoteStagingOntoCanonical\nrename to canonical real dir]
    L --> M{repointSiblingTargets}
    M -->|success| N[finalizeVendoredEntry\nmode:vendor, VendorPath, SubtreeHash]
    M -->|failure| O[os.RemoveAll canonicalAbs\nreturn error]
    O --> P[rollbackLinks created\nreturn error]
    N --> Q[lock.Write\nmode:vendor]
    Q -->|success| R[InstallResult\nWorktree=vendorDir]
    Q -->|failure| S[rollbackVendoredInstall\nRemoveAll vendorDir + symlinks]

Loading

_{Reviews (5): Last reviewed commit: "fix(skill): clean up vendored dir when l..." | Re-trigger Greptile}

[greptile-apps]

Want your agent to iterate on Greptile's feedback? Try greploops.

[raks097]

Addressed the 4/5 finding (multi-target sibling relink) in 2472958: the shared eject/vendor orchestrator now os.RemoveAll(canonicalAbs) when repointSiblingTargets fails, so a partial multi-target vendor no longer orphans the canonical real directory (which previously blocked future installs). The caller still rolls back the target symlinks, so eject/vendor is atomic.

[raks097]

Addressed the 4/5 finding (lock.Write failure orphaning the vendored dir) in f945c8d: both single-install paths now clean up the canonical real directory on a post-vendor lock.Write failure — InstallLocal via rollbackVendoredInstall (links + dir), and the Install registry wrapper via rollbackInstallResult (undoes the InstallInto links + the vendored dir from the returned result). A retry no longer hits "exists and is not a symlink".