Support Cargo features in verify and build - #42
Merged
Conversation
Contributor
Author
Collaborator
|
Maybe request for review next time |
Contributor
Author
No permissions to do that 😭 |
Marsman1996
requested changes
Aug 17, 2026
Marsman1996
left a comment
Marsman1996
left a comment
Collaborator
There was a problem hiding this comment.
Seems we shall push --features before --target
Marsman1996
requested changes
Aug 17, 2026
Marsman1996
approved these changes
Aug 17, 2026
Marsman1996
left a comment
Marsman1996
left a comment
Collaborator
There was a problem hiding this comment.
LGTM for the feature feature added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After some considerations I think there is no need to support full Cargo args for now as the use cases are limited so we might as well add args in an ad hoc way