fix: improve withdrawal queue fairness#592
Open
Mosas2000 wants to merge 1 commit into
Open
Conversation
Contributor
|
LGTM. Thanks for tackling this, the counter key fix, the checked-arithmetic helpers, and the aged-request priority concept are all the right calls. Please, fix CI/CD errors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes withdrawal queue starvation under sustained high pool utilization by adding fair partial fulfillment, cancellable queued requests, and investor-facing wait estimates.
What Changed
cancel_withdrawal_request.estimate_withdrawal_waitto expose:max_withdrawal_queue_age_daysto pool config with an admin setter.Why
The previous queue could leave late investors waiting indefinitely when utilization stayed near 100% and repayments were continuously redeployed. This change gives queued investors better visibility and ensures repayment liquidity is shared fairly instead of only serving the front of the queue.
Testing
git diff --checkpassed.cargo test -p poolwas not run becausecargois unavailable in the local environment.npm run typecheckwas not run becausetscis unavailable in the local environment.Fixes
Closes #574