Skip to content

Remove disconnected Citrine benchmark profiles - #2218

Merged
LoopedBard3 merged 1 commit into
aspnet:mainfrom
LoopedBard3:loopedbard3-disconnected-citrine-cleanup
Oct 19, 2026
Merged

LoopedBard3 merged 1 commit into
aspnet:mainfrom
LoopedBard3:loopedbard3-disconnected-citrine-cleanup

Conversation

@LoopedBard3

Copy link
Copy Markdown
Contributor

Summary

  • Remove disconnected Citrine and dependent ARM/Siryn profiles from legacy, standard, CI, and inline benchmark configurations.
  • Update stale examples and use shared profiles for the JSON and BuildPerformance configurations; replace the obsolete JSON WrkClient import with the current Crank Wrk job.
  • Correct the Gold Windows relay database address to 10.0.0.125, matching Gold direct, standard, and CI configurations.
  • Preserve active citrine1/citrine2/citrine3 controller queues and all generated scheduling configuration.

Context

Authenticated Azure inventory confirmed citrinelin, citrinedb, and citrineload have zero connected listeners; citrinearmlin, citrinearmwin, citrinearm, and sirynlin no longer exist. This completes the remaining profile cleanup after #2169. A separate PR migrates the PR-benchmark bot's machine selections to Gold.

Validation

  • All 43 existing pod-scheduler unit tests pass, including generation snapshots.
  • Edited YAML parses; surviving profiles are semantically unchanged except the Gold Windows DB correction.
  • Regular, Azure, and Cobalt pod profile references resolve; scheduler configuration and generated YAML are byte-for-byte unchanged.
  • Crank debug composition resolves JSON Gold Linux and BuildPerformance Gold Windows relay configurations. No benchmark workloads were launched.

Remove retired Citrine and dependent ARM/Siryn profile definitions, update examples to active Gold profiles, and reuse shared profiles in legacy scenarios. Correct the Gold Windows relay database address while preserving controller queues and active machine configurations.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 947a7758-5660-4f23-b447-e7006ace68fd

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The scoped configuration cleanup has no identified blocking issues, and reported validation covers profile composition and scheduler preservation.

No open issues 🎉

What changed in this PR

Completes the retired-machine profile cleanup following #2169 while preserving active controller queues and generated scheduling configuration.

Changes:

  • Remove disconnected Citrine and dependent ARM/Siryn profiles.
  • Update examples, reuse shared profiles, and replace the obsolete JSON Wrk import.
  • Correct the Gold Windows relay database address to 10.0.0.125.
File Description
src/​BenchmarksApps/​Samples/​Template/​sample.yml Update example comment to Gold Linux.
src/​BenchmarksApps/​BuildPerformance/​buildperformance.yml Replace inline Citrine profile with shared profiles.
src/​Benchmarks/​json.benchmarks.yml Import shared profiles and current Wrk job; refresh example.
scenarios/​README.md Update profile documentation and GC example.
scenarios/​platform.benchmarks.yml Update example comment to Gold Linux.
scenarios/​mono.benchmarks.yml Update example comment to Gold Linux.
scenarios/​aspnet.profiles.yml Remove retired profiles and correct Gold database address.
scenarios/​aspnet.profiles.standard.yml Remove retired ARM and Siryn profiles.
build/​ci.profile.yml Remove retired CI machine profiles.

Review effort: Balanced

@DrewScoggins DrewScoggins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DrewScoggins DrewScoggins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LoopedBard3
LoopedBard3 merged commit 9dd895b into aspnet:main Oct 19, 2026
2 checks passed
@LoopedBard3
LoopedBard3 deleted the loopedbard3-disconnected-citrine-cleanup branch October 19, 2026 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants