Plan: merge Electron smoke tests into the shared mobile harness - #2
Draft
ashleydavis wants to merge 2 commits into
Draft
Plan: merge Electron smoke tests into the shared mobile harness#2ashleydavis wants to merge 2 commits into
ashleydavis wants to merge 2 commits into
Conversation
Documents folding apps/desktop/smoke-tests into apps/smoke-tests behind PLATFORM=electron, retiring the in-process TestControlServer, and covering gaps the earlier mobile-branch draft missed (two-app LAN, parallel runner, platform skips, and other common.sh consumers). Co-authored-by: Ashley Davis <ashley@codecapers.com.au>
Absorbs the earlier plan-electron-host-bridge-smoke-tests draft (constraints, driver/bridge steps, verify notes) into the merge plan and leaves a done/ pointer so there is a single plan of record. Co-authored-by: Ashley Davis <ashley@codecapers.com.au>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Folds the older host-bridge draft into a single plan of record for merging Electron smoke tests into the shared mobile harness.
Plan of record
docs/plans/new/plan-merge-electron-into-mobile-smoke-tests.mdWhat changed in this PR
docs/plans/done/plan-electron-host-bridge-smoke-tests.md; delete thenew/copy onorigin/mobilewhen implementingScope of the plan
apps/smoke-testsasPLATFORM=electronTestControlServer.sequential), andtest:electronintest:allcommon.shImplementation must land on a branch based on
origin/mobile(or onmainafter mobile merges). This PR only adds/updates plan docs.